Re: [PATCH 3/4] media: af9035: add support for Logilink VG0022A

2019-10-10 Thread Gon Solo
Hi! This patch works for me. It disables firmware downloading for the si2157 instead of the si2168. Convert si2157 and si2168 to kernel-doc format as suggested by Mauro. Use bits instead of bool. Add a flag to si2157 for not loading the firmware. Make computation of speed register clear. Add ha

Re: [PATCH 3/4] media: af9035: add support for Logilink VG0022A

2019-10-10 Thread Gon Solo
Hi! I rebased Mauros patch on top of mine and this patch [3/4] is the first bad commit. I believe these lines are the culprit: + if (le16_to_cpu(d->udev->descriptor.idVendor) == USB_VID_DEXATEK && + le16_to_cpu(d->udev->descriptor.idProduct) == 0x0100) + si2168_confi

Re: [PATCH 3/4] media: af9035: add support for Logilink VG0022A

2019-10-09 Thread Gon Solo
> Unfortunately, after applying these four patches it doesn't work for me. Your patch disables firmware loading at dvb-frontends/si2168.c:449 while my original one disabled it at tuners/si2157.c:554: case SI_BOGUS: dev_info(&client->dev, "bogus chip version, trying with no

Re: [PATCH 3/4] media: af9035: add support for Logilink VG0022A

2019-10-09 Thread Gon Solo
> This it930x-based device has an issue with si2068. > > When the si2168 firmware that came with the device is replaced > by a new one, any I2C data received from the tuner will be > replaced by 0xff. > > Probably, the vendor firmware has some patch specifically > designed for this device. So, we

[PATCH 3/4] media: af9035: add support for Logilink VG0022A

2019-10-04 Thread Mauro Carvalho Chehab
This it930x-based device has an issue with si2068. When the si2168 firmware that came with the device is replaced by a new one, any I2C data received from the tuner will be replaced by 0xff. Probably, the vendor firmware has some patch specifically designed for this device. So, we can't replace b