Re: [PATCH 3/4] media: sunxi-cir: Factor out hardware initialization

2021-01-13 Thread Sean Young
Hi Samuel, On Wed, Jan 13, 2021 at 09:00:20AM -0600, Samuel Holland wrote: > On 1/13/21 8:36 AM, Sean Young wrote: > > On Tue, Jan 12, 2021 at 10:51:31PM -0600, Samuel Holland wrote: > >> In preparation for adding suspend/resume hooks, factor out the hardware > >> initialization from the driver

Re: [PATCH 3/4] media: sunxi-cir: Factor out hardware initialization

2021-01-13 Thread Samuel Holland
On 1/13/21 8:36 AM, Sean Young wrote: > On Tue, Jan 12, 2021 at 10:51:31PM -0600, Samuel Holland wrote: >> In preparation for adding suspend/resume hooks, factor out the hardware >> initialization from the driver probe/remove functions. >> >> The timeout programmed during init is taken from the

Re: [PATCH 3/4] media: sunxi-cir: Factor out hardware initialization

2021-01-13 Thread Sean Young
On Tue, Jan 12, 2021 at 10:51:31PM -0600, Samuel Holland wrote: > In preparation for adding suspend/resume hooks, factor out the hardware > initialization from the driver probe/remove functions. > > The timeout programmed during init is taken from the `struct rc_dev` so > it is maintained across

[PATCH 3/4] media: sunxi-cir: Factor out hardware initialization

2021-01-12 Thread Samuel Holland
In preparation for adding suspend/resume hooks, factor out the hardware initialization from the driver probe/remove functions. The timeout programmed during init is taken from the `struct rc_dev` so it is maintained across an exit/init cycle. This resolves some trivial issues with the probe