Re: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-04-01 Thread Rik van Riel
Johannes Weiner; Mel Gorman; Rik van Riel; Shaohua Li; Wang, Yalin; Minchan >> Kim >> Subject: [PATCH 3/4] mm: move lazy free pages to inactive list >> >> MADV_FREE is hint that it's okay to discard pages if there is >> memory pressure and we uses reclaimers(ie, ks

Re: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-30 Thread Minchan Kim
On Mon, Mar 30, 2015 at 10:28:47PM -0700, Andrew Morton wrote: > On Tue, 31 Mar 2015 13:45:25 +0900 Minchan Kim wrote: > > > > > > deactivate_page() doesn't look at or alter PageReferenced(). Should it? > > > > Absolutely true. Thanks. > > Here it goes. > > > > >From 2b2c92eb73a1cceac615b9abd4

Re: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-30 Thread Andrew Morton
On Tue, 31 Mar 2015 13:45:25 +0900 Minchan Kim wrote: > > > > deactivate_page() doesn't look at or alter PageReferenced(). Should it? > > Absolutely true. Thanks. > Here it goes. > > >From 2b2c92eb73a1cceac615b9abd4c0f5f0c3395ff5 Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Tue, 31 Ma

Re: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-30 Thread Minchan Kim
Hello Andrew, On Mon, Mar 30, 2015 at 02:20:10PM -0700, Andrew Morton wrote: > On Mon, 30 Mar 2015 14:35:02 +0900 Minchan Kim wrote: > > > --- a/mm/swap.c > > +++ b/mm/swap.c > > @@ -866,6 +866,13 @@ void deactivate_file_page(struct page *page) > > } > > } > > > > +/** > > + * deactivate_

Re: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-30 Thread Andrew Morton
On Mon, 30 Mar 2015 14:35:02 +0900 Minchan Kim wrote: > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -866,6 +866,13 @@ void deactivate_file_page(struct page *page) > } > } > > +/** > + * deactivate_page - deactivate a page > + * @page: page to deactivate > + * > + * This function moves @page t

Re: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-29 Thread Minchan Kim
Hello Andrew, On Fri, Mar 20, 2015 at 03:43:58PM -0700, Andrew Morton wrote: > On Wed, 11 Mar 2015 10:20:37 +0900 Minchan Kim wrote: > > > MADV_FREE is hint that it's okay to discard pages if there is > > memory pressure and we uses reclaimers(ie, kswapd and direct reclaim) > > to free them so t

Re: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-20 Thread Andrew Morton
On Wed, 11 Mar 2015 10:20:37 +0900 Minchan Kim wrote: > MADV_FREE is hint that it's okay to discard pages if there is > memory pressure and we uses reclaimers(ie, kswapd and direct reclaim) > to free them so there is no worth to remain them in active anonymous LRU > so this patch moves them to in

Re: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-10 Thread Minchan Kim
rg; Michal Hocko; > > Johannes Weiner; Mel Gorman; Rik van Riel; Shaohua Li; Wang, Yalin; Minchan > > Kim > > Subject: [PATCH 3/4] mm: move lazy free pages to inactive list > > > > MADV_FREE is hint that it's okay to discard pages if there is > > memory pressure

RE: [PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-10 Thread Wang, Yalin
lin; Minchan > Kim > Subject: [PATCH 3/4] mm: move lazy free pages to inactive list > > MADV_FREE is hint that it's okay to discard pages if there is > memory pressure and we uses reclaimers(ie, kswapd and direct reclaim) > to free them so there is no worth to remain them in active

[PATCH 3/4] mm: move lazy free pages to inactive list

2015-03-10 Thread Minchan Kim
MADV_FREE is hint that it's okay to discard pages if there is memory pressure and we uses reclaimers(ie, kswapd and direct reclaim) to free them so there is no worth to remain them in active anonymous LRU so this patch moves them to inactive LRU list's head. This means that MADV_FREE-ed pages whic