Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-11 Thread Michal Hocko
On Tue 11-10-16 16:37:16, Minchan Kim wrote: > On Tue, Oct 11, 2016 at 09:26:06AM +0200, Michal Hocko wrote: > > On Tue 11-10-16 16:09:45, Minchan Kim wrote: [...] > > > @@ -2154,12 +2156,24 @@ static void unreserve_highatomic_pageblock(const > > > struct alloc_context *ac) > > >

Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-11 Thread Minchan Kim
On Tue, Oct 11, 2016 at 09:26:06AM +0200, Michal Hocko wrote: > On Tue 11-10-16 16:09:45, Minchan Kim wrote: > > On Tue, Oct 11, 2016 at 08:50:48AM +0200, Michal Hocko wrote: > > > On Tue 11-10-16 14:01:41, Minchan Kim wrote: > [...] > > > > Also, your patch makes retry loop greater than MAX_RECLAI

Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-11 Thread Michal Hocko
On Tue 11-10-16 16:09:45, Minchan Kim wrote: > On Tue, Oct 11, 2016 at 08:50:48AM +0200, Michal Hocko wrote: > > On Tue 11-10-16 14:01:41, Minchan Kim wrote: [...] > > > Also, your patch makes retry loop greater than MAX_RECLAIM_RETRIES > > > if unreserve_highatomic_pageblock returns true. Theoreti

Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-11 Thread Minchan Kim
On Tue, Oct 11, 2016 at 08:50:48AM +0200, Michal Hocko wrote: > On Tue 11-10-16 14:01:41, Minchan Kim wrote: > > Hi Michal, > > > > On Mon, Oct 10, 2016 at 09:41:40AM +0200, Michal Hocko wrote: > > > On Fri 07-10-16 23:43:45, Minchan Kim wrote: > > > > On Fri, Oct 07, 2016 at 11:09:17AM +0200, Mic

Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-10 Thread Michal Hocko
On Tue 11-10-16 14:01:41, Minchan Kim wrote: > Hi Michal, > > On Mon, Oct 10, 2016 at 09:41:40AM +0200, Michal Hocko wrote: > > On Fri 07-10-16 23:43:45, Minchan Kim wrote: > > > On Fri, Oct 07, 2016 at 11:09:17AM +0200, Michal Hocko wrote: [...] > > > > @@ -2102,10 +2109,12 @@ static void > > >

Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-10 Thread Minchan Kim
Hi Michal, On Mon, Oct 10, 2016 at 09:41:40AM +0200, Michal Hocko wrote: > On Fri 07-10-16 23:43:45, Minchan Kim wrote: > > On Fri, Oct 07, 2016 at 11:09:17AM +0200, Michal Hocko wrote: > > > On Fri 07-10-16 14:45:35, Minchan Kim wrote: > > > > After fixing the race of highatomic page count, I sti

Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-10 Thread Michal Hocko
On Fri 07-10-16 23:43:45, Minchan Kim wrote: > On Fri, Oct 07, 2016 at 11:09:17AM +0200, Michal Hocko wrote: > > On Fri 07-10-16 14:45:35, Minchan Kim wrote: > > > After fixing the race of highatomic page count, I still encounter > > > OOM with many free memory reserved as highatomic. > > > > > >

Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-07 Thread Minchan Kim
On Fri, Oct 07, 2016 at 11:09:17AM +0200, Michal Hocko wrote: > On Fri 07-10-16 14:45:35, Minchan Kim wrote: > > After fixing the race of highatomic page count, I still encounter > > OOM with many free memory reserved as highatomic. > > > > One of reason in my testing was we unreserve free pages o

Re: [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-07 Thread Michal Hocko
On Fri 07-10-16 14:45:35, Minchan Kim wrote: > After fixing the race of highatomic page count, I still encounter > OOM with many free memory reserved as highatomic. > > One of reason in my testing was we unreserve free pages only if > reclaim has progress. Otherwise, we cannot have chance to unres

[PATCH 3/4] mm: unreserve highatomic free pages fully before OOM

2016-10-06 Thread Minchan Kim
After fixing the race of highatomic page count, I still encounter OOM with many free memory reserved as highatomic. One of reason in my testing was we unreserve free pages only if reclaim has progress. Otherwise, we cannot have chance to unreseve. Other problem after fixing it was it doesn't guar