Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-16 Thread Andrew Morton
On Tue, 16 Oct 2018 09:49:23 +0100 Mel Gorman wrote: > > Can we do this? > > > > --- a/mm/workingset.c~mm-workingset-add-vmstat-counter-for-shadow-nodes-fix > > +++ a/mm/workingset.c > > @@ -377,6 +377,8 @@ void workingset_update_node(struct radix > > * already where they should be. The

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-16 Thread Andrew Morton
On Tue, 16 Oct 2018 09:49:23 +0100 Mel Gorman wrote: > > Can we do this? > > > > --- a/mm/workingset.c~mm-workingset-add-vmstat-counter-for-shadow-nodes-fix > > +++ a/mm/workingset.c > > @@ -377,6 +377,8 @@ void workingset_update_node(struct radix > > * already where they should be. The

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-16 Thread Mel Gorman
On Tue, Oct 09, 2018 at 03:08:45PM -0700, Andrew Morton wrote: > On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > > > --- a/mm/workingset.c > > +++ b/mm/workingset.c > > @@ -378,11 +378,17 @@ void workingset_update_node(struct xa_node *node) > > * as node->private_list is

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-16 Thread Mel Gorman
On Tue, Oct 09, 2018 at 03:08:45PM -0700, Andrew Morton wrote: > On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > > > --- a/mm/workingset.c > > +++ b/mm/workingset.c > > @@ -378,11 +378,17 @@ void workingset_update_node(struct xa_node *node) > > * as node->private_list is

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-10 Thread Johannes Weiner
On Tue, Oct 09, 2018 at 03:08:45PM -0700, Andrew Morton wrote: > On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > > > --- a/mm/workingset.c > > +++ b/mm/workingset.c > > @@ -378,11 +378,17 @@ void workingset_update_node(struct xa_node *node) > > * as node->private_list is

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-10 Thread Johannes Weiner
On Tue, Oct 09, 2018 at 03:08:45PM -0700, Andrew Morton wrote: > On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > > > --- a/mm/workingset.c > > +++ b/mm/workingset.c > > @@ -378,11 +378,17 @@ void workingset_update_node(struct xa_node *node) > > * as node->private_list is

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-10 Thread Johannes Weiner
On Tue, Oct 09, 2018 at 03:04:01PM -0700, Andrew Morton wrote: > On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > > > Make it easier to catch bugs in the shadow node shrinker by adding a > > counter for the shadow nodes in circulation. > > > > Signed-off-by: Johannes Weiner > > ---

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-10 Thread Johannes Weiner
On Tue, Oct 09, 2018 at 03:04:01PM -0700, Andrew Morton wrote: > On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > > > Make it easier to catch bugs in the shadow node shrinker by adding a > > counter for the shadow nodes in circulation. > > > > Signed-off-by: Johannes Weiner > > ---

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -378,11 +378,17 @@ void workingset_update_node(struct xa_node *node) >* as node->private_list is protected by the i_pages lock. >*/ > if (node->count &&

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -378,11 +378,17 @@ void workingset_update_node(struct xa_node *node) >* as node->private_list is protected by the i_pages lock. >*/ > if (node->count &&

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > Make it easier to catch bugs in the shadow node shrinker by adding a > counter for the shadow nodes in circulation. > > Signed-off-by: Johannes Weiner > --- > include/linux/mmzone.h | 1 + > mm/vmstat.c| 1 + >

Re: [PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-09 Thread Andrew Morton
On Tue, 9 Oct 2018 14:47:32 -0400 Johannes Weiner wrote: > Make it easier to catch bugs in the shadow node shrinker by adding a > counter for the shadow nodes in circulation. > > Signed-off-by: Johannes Weiner > --- > include/linux/mmzone.h | 1 + > mm/vmstat.c| 1 + >

[PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-09 Thread Johannes Weiner
Make it easier to catch bugs in the shadow node shrinker by adding a counter for the shadow nodes in circulation. Signed-off-by: Johannes Weiner --- include/linux/mmzone.h | 1 + mm/vmstat.c| 1 + mm/workingset.c| 12 ++-- 3 files changed, 12 insertions(+), 2

[PATCH 3/4] mm: workingset: add vmstat counter for shadow nodes

2018-10-09 Thread Johannes Weiner
Make it easier to catch bugs in the shadow node shrinker by adding a counter for the shadow nodes in circulation. Signed-off-by: Johannes Weiner --- include/linux/mmzone.h | 1 + mm/vmstat.c| 1 + mm/workingset.c| 12 ++-- 3 files changed, 12 insertions(+), 2