Re: [PATCH 3/4] mmc: mediatek: Add tune support

2015-10-15 Thread Chaotian Jing
On Thu, 2015-10-15 at 11:17 +0200, Ulf Hansson wrote: > [...] > > >> > > >> > struct clk *src_clk;/* msdc source clock */ > >> > + struct clk *src_clk_parent; /* src_clk's parent */ > >> > + struct clk *hs400_src; /* 400Mhz source clock */ > >> > >> Hmm, so you need to con

Re: [PATCH 3/4] mmc: mediatek: Add tune support

2015-10-15 Thread Ulf Hansson
[...] >> > >> > struct clk *src_clk;/* msdc source clock */ >> > + struct clk *src_clk_parent; /* src_clk's parent */ >> > + struct clk *hs400_src; /* 400Mhz source clock */ >> >> Hmm, so you need to control the upper level clocks. Can you elaborate >> on why this is neede

Re: [PATCH 3/4] mmc: mediatek: Add tune support

2015-10-14 Thread Sascha Hauer
On Thu, Oct 15, 2015 at 10:46:20AM +0800, Chaotian Jing wrote: > On Wed, 2015-10-14 at 12:05 +0200, Ulf Hansson wrote: > > On 13 October 2015 at 11:37, Chaotian Jing > > wrote: > > > Add CMD19/CMD21 support for EMMC/SD/SDIO tuning > > > Add HS400 mode support > > > > > > Signed-off-by: Chaotian J

Re: [PATCH 3/4] mmc: mediatek: Add tune support

2015-10-14 Thread Sascha Hauer
Hi, On Tue, Oct 13, 2015 at 05:37:57PM +0800, Chaotian Jing wrote: > @@ -1260,6 +1547,16 @@ static int msdc_drv_probe(struct platform_device *pdev) > goto host_free; > } > > + host->src_clk_parent = clk_get_parent(host->src_clk); > + host->hs400_src = devm_clk_get(&pd

Re: [PATCH 3/4] mmc: mediatek: Add tune support

2015-10-14 Thread Chaotian Jing
On Wed, 2015-10-14 at 12:05 +0200, Ulf Hansson wrote: > On 13 October 2015 at 11:37, Chaotian Jing wrote: > > Add CMD19/CMD21 support for EMMC/SD/SDIO tuning > > Add HS400 mode support > > > > Signed-off-by: Chaotian Jing > > --- > > drivers/mmc/host/mtk-sd.c | 359 > > +

Re: [PATCH 3/4] mmc: mediatek: Add tune support

2015-10-14 Thread Ulf Hansson
On 13 October 2015 at 11:37, Chaotian Jing wrote: > Add CMD19/CMD21 support for EMMC/SD/SDIO tuning > Add HS400 mode support > > Signed-off-by: Chaotian Jing > --- > drivers/mmc/host/mtk-sd.c | 359 > ++ > 1 file changed, 332 insertions(+), 27 deletio

[PATCH 3/4] mmc: mediatek: Add tune support

2015-10-13 Thread Chaotian Jing
Add CMD19/CMD21 support for EMMC/SD/SDIO tuning Add HS400 mode support Signed-off-by: Chaotian Jing --- drivers/mmc/host/mtk-sd.c | 359 ++ 1 file changed, 332 insertions(+), 27 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mt