Re: [PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-29 Thread Govindarajulu Varadarajan
On Fri, 29 Sep 2017, Sinan Kaya wrote: On 9/28/2017 7:46 PM, Govindarajulu Varadarajan wrote: How about releasing the device_lock here on CPU0?> pci_device_add() is called by driver's pci probe function. device_lock(dev) should be held before calling pci driver probe function. I see. The go

Re: [PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-29 Thread Sinan Kaya
On 9/28/2017 7:46 PM, Govindarajulu Varadarajan wrote: >> How about releasing the device_lock here on CPU0?> > > pci_device_add() is called by driver's pci probe function. device_lock(dev) > should be held before calling pci driver probe function. I see. The goal of the lock held here is to prote

Re: [PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-28 Thread Govindarajulu Varadarajan
On Thu, 28 Sep 2017, Sinan Kaya wrote: On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote: CPU0CPU1 - __driver_attach() device_lock(&dev->mutex) <--- device mutex lock here driver_probe_de

Re: [PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-28 Thread Sinan Kaya
On 9/27/2017 5:42 PM, Govindarajulu Varadarajan wrote: > CPU0 CPU1 > - > __driver_attach() > device_lock(&dev->mutex) <--- device mutex lock here > driver_probe_device() > pci_enable_sriov() > pci_i

[PATCH 3/4] pci aer: fix deadlock in do_recovery

2017-09-27 Thread Govindarajulu Varadarajan
CPU0CPU1 - __driver_attach() device_lock(&dev->mutex) <--- device mutex lock here driver_probe_device() pci_enable_sriov() pci_iov_add_virtfn() pci_device_add()