Re: [PATCH 3/4] perf/x86/mbm: Fix mbm counting when RMIDs are reused

2016-04-25 Thread Vikas Shivappa
'per event' rc_count = read_sample(event->rmid) - per event start count; 'per event' rc_count += read_sample(event->rmid) - per event start count;

Re: [PATCH 3/4] perf/x86/mbm: Fix mbm counting when RMIDs are reused

2016-04-25 Thread Vikas Shivappa
On Mon, 25 Apr 2016, Peter Zijlstra wrote: On Mon, Apr 25, 2016 at 09:44:53AM -0700, Vikas Shivappa wrote: On Mon, 25 Apr 2016, Peter Zijlstra wrote: On Fri, Apr 22, 2016 at 05:27:20PM -0700, Vikas Shivappa wrote: When multiple instances of perf reuse RMID, then we need to start counting

Re: [PATCH 3/4] perf/x86/mbm: Fix mbm counting when RMIDs are reused

2016-04-25 Thread Peter Zijlstra
On Mon, Apr 25, 2016 at 09:44:53AM -0700, Vikas Shivappa wrote: > > > On Mon, 25 Apr 2016, Peter Zijlstra wrote: > > >On Fri, Apr 22, 2016 at 05:27:20PM -0700, Vikas Shivappa wrote: > >>When multiple instances of perf reuse RMID, then we need to start > >>counting for each instance rather than r

Re: [PATCH 3/4] perf/x86/mbm: Fix mbm counting when RMIDs are reused

2016-04-25 Thread Vikas Shivappa
On Mon, 25 Apr 2016, Peter Zijlstra wrote: On Fri, Apr 22, 2016 at 05:27:20PM -0700, Vikas Shivappa wrote: When multiple instances of perf reuse RMID, then we need to start counting for each instance rather than reporting the current RMID count. This patch adds a st_count(start count) per eve

Re: [PATCH 3/4] perf/x86/mbm: Fix mbm counting when RMIDs are reused

2016-04-25 Thread Peter Zijlstra
On Fri, Apr 22, 2016 at 05:27:20PM -0700, Vikas Shivappa wrote: > When multiple instances of perf reuse RMID, then we need to start > counting for each instance rather than reporting the current RMID count. > This patch adds a st_count(start count) per event to track the same. what?

[PATCH 3/4] perf/x86/mbm: Fix mbm counting when RMIDs are reused

2016-04-22 Thread Vikas Shivappa
When multiple instances of perf reuse RMID, then we need to start counting for each instance rather than reporting the current RMID count. This patch adds a st_count(start count) per event to track the same. Signed-off-by: Vikas Shivappa --- arch/x86/events/intel/cqm.c | 71 +