Re: [PATCH 3/4] perf archive: Fix filtering of empty build-ids

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Fri, Feb 12, 2021 at 01:49:36PM -0500, Nicholas Fraser escreveu: > The current version of "perf buildid-list" prints missing build-ids as > blank even when loading perf.data files generated from older versions of > perf. I've tested with a few older versions. > > Since perf-archive is an

Re: [PATCH 3/4] perf archive: Fix filtering of empty build-ids

2021-02-12 Thread Nicholas Fraser
The current version of "perf buildid-list" prints missing build-ids as blank even when loading perf.data files generated from older versions of perf. I've tested with a few older versions. Since perf-archive is an external script that calls back into perf, it could in theory find a different

Re: [PATCH 3/4] perf archive: Fix filtering of empty build-ids

2021-02-12 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 10, 2021 at 02:17:49PM -0500, Nicholas Fraser escreveu: > A non-existent build-id used to be treated as all-zero SHA-1 hash. > Build-ids are now variable width. A non-existent build-id is an empty > string and "perf buildid-list" pads this with spaces. > > This fixes "perf-archive" to

[PATCH 3/4] perf archive: Fix filtering of empty build-ids

2021-02-10 Thread Nicholas Fraser
A non-existent build-id used to be treated as all-zero SHA-1 hash. Build-ids are now variable width. A non-existent build-id is an empty string and "perf buildid-list" pads this with spaces. This fixes "perf-archive" to skip missing build-ids by skipping lines that start with a padding space