Re: [PATCH 3/4] perf inject --jit: Remove //anon mmap events

2019-10-03 Thread Jiri Olsa
On Wed, Oct 02, 2019 at 01:58:21PM -0700, Steve MacLean wrote: > From: Steve MacLean > > While a JIT is jitting code it will eventually need to commit more pages and > change these pages to executable permissions. > > Typically the JIT will want these colocated to minimize branch displacements.

[PATCH 3/4] perf inject --jit: Remove //anon mmap events

2019-10-02 Thread Steve MacLean
From: Steve MacLean While a JIT is jitting code it will eventually need to commit more pages and change these pages to executable permissions. Typically the JIT will want these colocated to minimize branch displacements. The kernel will coalesce these anonymous mapping with identical

Re: [PATCH 3/4] perf inject --jit: Remove //anon mmap events

2019-09-30 Thread Andi Kleen
On Mon, Sep 30, 2019 at 08:49:00PM +, Steve MacLean wrote: > SNIP > > > I can't apply this one: > > > patching file builtin-inject.c > > Hunk #1 FAILED at 263. > > 1 out of 1 hunk FAILED -- saving rejects to file builtin-inject.c.rej > > I assume this is because I based my patches on the

RE: [PATCH 3/4] perf inject --jit: Remove //anon mmap events

2019-09-30 Thread Steve MacLean
SNIP > I can't apply this one: > patching file builtin-inject.c > Hunk #1 FAILED at 263. > 1 out of 1 hunk FAILED -- saving rejects to file builtin-inject.c.rej I assume this is because I based my patches on the wrong tip. > patching file util/jitdump.c > patch: malformed patch at line

Re: [PATCH 3/4] perf inject --jit: Remove //anon mmap events

2019-09-29 Thread Jiri Olsa
On Sat, Sep 28, 2019 at 01:45:36AM +, Steve MacLean wrote: > While a JIT is jitting code it will eventually need to commit more pages and > change these pages to executable permissions. > > Typically the JIT will want these co-located to minimize branch displacements. > > The kernel will

[PATCH 3/4] perf inject --jit: Remove //anon mmap events

2019-09-27 Thread Steve MacLean
While a JIT is jitting code it will eventually need to commit more pages and change these pages to executable permissions. Typically the JIT will want these co-located to minimize branch displacements. The kernel will coalesce these anonymous mapping with identical permissions before sending an