Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-11-01 Thread Jiri Olsa
On Tue, Oct 29, 2013 at 11:18:21AM +0100, Jiri Olsa wrote: > On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: > > On Sat, 26 Oct 2013 16:25:35 +0200, Jiri Olsa wrote: > > > Adding call-graph option support into .perfconfig file, > > > so it's now possible use call-graph option like: >

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-11-01 Thread Jiri Olsa
On Tue, Oct 29, 2013 at 11:18:21AM +0100, Jiri Olsa wrote: On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: On Sat, 26 Oct 2013 16:25:35 +0200, Jiri Olsa wrote: Adding call-graph option support into .perfconfig file, so it's now possible use call-graph option like:

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-29 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 29, 2013 at 11:18:21AM +0100, Jiri Olsa escreveu: > > On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: > > > > + opts->call_graph_enabled = !unset; > > > > + > > > > > > Why not just using symbol_conf.use_callchain? > > > > >

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-29 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 29, 2013 at 11:18:21AM +0100, Jiri Olsa escreveu: > On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: > > > + opts->call_graph_enabled = !unset; > > > + > > > > Why not just using symbol_conf.use_callchain? > > > > right, this way we'd be in sync with top Cool, so a

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-29 Thread Jiri Olsa
On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: > On Sat, 26 Oct 2013 16:25:35 +0200, Jiri Olsa wrote: > > Adding call-graph option support into .perfconfig file, > > so it's now possible use call-graph option like: > > > > [top] > > call-graph = fp > > > > [record] > >

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-29 Thread Jiri Olsa
On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: On Sat, 26 Oct 2013 16:25:35 +0200, Jiri Olsa wrote: Adding call-graph option support into .perfconfig file, so it's now possible use call-graph option like: [top] call-graph = fp [record] call-graph

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-29 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 29, 2013 at 11:18:21AM +0100, Jiri Olsa escreveu: On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: + opts-call_graph_enabled = !unset; + Why not just using symbol_conf.use_callchain? right, this way we'd be in sync with top Cool, so a patch on top of

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-29 Thread Ingo Molnar
* Arnaldo Carvalho de Melo a...@redhat.com wrote: Em Tue, Oct 29, 2013 at 11:18:21AM +0100, Jiri Olsa escreveu: On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: + opts-call_graph_enabled = !unset; + Why not just using symbol_conf.use_callchain?

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-28 Thread Namhyung Kim
On Sat, 26 Oct 2013 16:25:35 +0200, Jiri Olsa wrote: > Adding call-graph option support into .perfconfig file, > so it's now possible use call-graph option like: > > [top] > call-graph = fp > > [record] > call-graph = dwarf,8192 > > Above options ONLY setup the unwind method.

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-28 Thread Namhyung Kim
On Sat, 26 Oct 2013 16:25:35 +0200, Jiri Olsa wrote: Adding call-graph option support into .perfconfig file, so it's now possible use call-graph option like: [top] call-graph = fp [record] call-graph = dwarf,8192 Above options ONLY setup the unwind method. To enable

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-27 Thread David Ahern
On 10/26/13 8:25 AM, Jiri Olsa wrote: Adding call-graph option support into .perfconfig file, so it's now possible use call-graph option like: [top] call-graph = fp [record] call-graph = dwarf,8192 Above options ONLY setup the unwind method. To enable perf record/top

Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-27 Thread David Ahern
On 10/26/13 8:25 AM, Jiri Olsa wrote: Adding call-graph option support into .perfconfig file, so it's now possible use call-graph option like: [top] call-graph = fp [record] call-graph = dwarf,8192 Above options ONLY setup the unwind method. To enable perf record/top

[PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-26 Thread Jiri Olsa
Adding call-graph option support into .perfconfig file, so it's now possible use call-graph option like: [top] call-graph = fp [record] call-graph = dwarf,8192 Above options ONLY setup the unwind method. To enable perf record/top to actually use it the command line option

[PATCH 3/4] perf tools: Add call-graph option support into .perfconfig

2013-10-26 Thread Jiri Olsa
Adding call-graph option support into .perfconfig file, so it's now possible use call-graph option like: [top] call-graph = fp [record] call-graph = dwarf,8192 Above options ONLY setup the unwind method. To enable perf record/top to actually use it the command line option