Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

2015-07-30 Thread Bjorn Andersson
On Mon 27 Jul 07:06 PDT 2015, Sebastian Reichel wrote: > Hi, > > On Sat, Jul 25, 2015 at 06:04:14PM -0700, Bjorn Andersson wrote: > > On Sat 25 Jul 08:42 PDT 2015, Sebastian Reichel wrote: > > > * battery-charge-control-limit > > > > > > It's unclear, what this property is used for. Is the limi

Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

2015-07-27 Thread Sebastian Reichel
Hi, On Sat, Jul 25, 2015 at 06:04:14PM -0700, Bjorn Andersson wrote: > On Sat 25 Jul 08:42 PDT 2015, Sebastian Reichel wrote: > > * battery-charge-control-limit > > > > It's unclear, what this property is used for. Is the limit only > > for "normal" charging or also for fast charging? > > > >

Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

2015-07-25 Thread Bjorn Andersson
On Sat 25 Jul 08:42 PDT 2015, Sebastian Reichel wrote: > Hi, > > On Thu, Jun 18, 2015 at 02:13:44PM -0700, Bjorn Andersson wrote: > > Add the Qualcomm Switch-Mode Battery Charger and Boost driver, found in > > pm8941. > > The driver's sourcecode looks fine to me. Thanks. > I'm not convinced by

Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

2015-07-25 Thread Sebastian Reichel
Hi, On Thu, Jun 18, 2015 at 02:13:44PM -0700, Bjorn Andersson wrote: > Add the Qualcomm Switch-Mode Battery Charger and Boost driver, found in > pm8941. The driver's sourcecode looks fine to me. I'm not convinced by all those new DT properties, though. I think "watermark" should be replaced with

Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

2015-06-21 Thread Bjorn Andersson
On Fri, Jun 19, 2015 at 10:01 AM, Paul Bolle wrote: > On Thu, 2015-06-18 at 14:13 -0700, Bjorn Andersson wrote: >> --- /dev/null >> +++ b/drivers/power/qcom_smbb.c > >> +MODULE_ALIAS("platform:qcom_smbb"); > > (The day before yesterday and yesterday I had a, well, lively > conversation regarding t

Re: [PATCH 3/4] power: Add Qualcomm SMBB driver

2015-06-19 Thread Paul Bolle
On Thu, 2015-06-18 at 14:13 -0700, Bjorn Andersson wrote: > --- /dev/null > +++ b/drivers/power/qcom_smbb.c > +MODULE_ALIAS("platform:qcom_smbb"); (The day before yesterday and yesterday I had a, well, lively conversation regarding this macro. The interesting bits start at https://lkml.org/lkml/2

[PATCH 3/4] power: Add Qualcomm SMBB driver

2015-06-18 Thread Bjorn Andersson
Add the Qualcomm Switch-Mode Battery Charger and Boost driver, found in pm8941. Signed-off-by: Courtney Cavin Signed-off-by: Bjorn Andersson --- The downstream (caf) driver for this hw block contains workarounds for a couple of claimed hw issues. The most noteworthy is the software base charge-