Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-13 Thread Petr Mladek
On Tue 2019-03-12 21:52:13, Calvin Owens wrote: > On Monday 03/11 at 14:33 +0100, Petr Mladek wrote: > > On Fri 2019-03-01 16:48:19, Calvin Owens wrote: > > > This patch embeds a device struct in the console struct, and registers > > > them on a "console" bus so we can expose attributes in sysfs.

Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-12 Thread Calvin Owens
On Monday 03/11 at 14:33 +0100, Petr Mladek wrote: > On Fri 2019-03-01 16:48:19, Calvin Owens wrote: > > This patch embeds a device struct in the console struct, and registers > > them on a "console" bus so we can expose attributes in sysfs. > > > > Currently, most drivers declare static console

Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-12 Thread Calvin Owens
On Friday 03/08 at 16:53 +0100, Petr Mladek wrote: > On Fri 2019-03-01 16:48:19, Calvin Owens wrote: > > This patch embeds a device struct in the console struct, and registers > > them on a "console" bus so we can expose attributes in sysfs. > > > > Early console structures must still be static,

Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-12 Thread Calvin Owens
On Friday 03/08 at 17:34 +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 08, 2019 at 04:58:14PM +0100, Petr Mladek wrote: > > On Fri 2019-03-08 03:56:19, John Ogness wrote: > > > On 2019-03-02, Calvin Owens wrote: > > > > This patch embeds a device struct in the console struct, and registers > > >

Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-11 Thread Petr Mladek
On Fri 2019-03-01 16:48:19, Calvin Owens wrote: > This patch embeds a device struct in the console struct, and registers > them on a "console" bus so we can expose attributes in sysfs. > > Currently, most drivers declare static console structs, and that is > incompatible with the dev refcount

Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-08 Thread Greg Kroah-Hartman
On Fri, Mar 08, 2019 at 04:58:14PM +0100, Petr Mladek wrote: > On Fri 2019-03-08 03:56:19, John Ogness wrote: > > On 2019-03-02, Calvin Owens wrote: > > > This patch embeds a device struct in the console struct, and registers > > > them on a "console" bus so we can expose attributes in sysfs. > >

Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-08 Thread Petr Mladek
On Fri 2019-03-08 03:56:19, John Ogness wrote: > On 2019-03-02, Calvin Owens wrote: > > This patch embeds a device struct in the console struct, and registers > > them on a "console" bus so we can expose attributes in sysfs. > > I expect that "class" would be more appropriate than "bus". These >

Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-08 Thread Petr Mladek
On Fri 2019-03-01 16:48:19, Calvin Owens wrote: > This patch embeds a device struct in the console struct, and registers > them on a "console" bus so we can expose attributes in sysfs. > > Early console structures must still be static, since they're required > before we're able to allocate

Re: [PATCH 3/4] printk: Add consoles to a virtual "console" bus

2019-03-07 Thread John Ogness
On 2019-03-02, Calvin Owens wrote: > This patch embeds a device struct in the console struct, and registers > them on a "console" bus so we can expose attributes in sysfs. I expect that "class" would be more appropriate than "bus". These devices really are grouped together based on their