Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Thomas Gleixner
On Thu, 20 Oct 2016, Nicolas Pitre wrote: > On Thu, 20 Oct 2016, Thomas Gleixner wrote: > > > On Wed, 19 Oct 2016, Nicolas Pitre wrote: > > > The pch_gbe driver is a bit special as it relies on extra code in > > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > > >

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Thomas Gleixner
On Thu, 20 Oct 2016, Nicolas Pitre wrote: > On Thu, 20 Oct 2016, Thomas Gleixner wrote: > > > On Wed, 19 Oct 2016, Nicolas Pitre wrote: > > > The pch_gbe driver is a bit special as it relies on extra code in > > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > > >

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Nicolas Pitre
On Thu, 20 Oct 2016, Thomas Gleixner wrote: > On Wed, 19 Oct 2016, Nicolas Pitre wrote: > > The pch_gbe driver is a bit special as it relies on extra code in > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > > drivers/ptp/ even if PTP_1588_CLOCK is unselected. > > The

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Nicolas Pitre
On Thu, 20 Oct 2016, Thomas Gleixner wrote: > On Wed, 19 Oct 2016, Nicolas Pitre wrote: > > The pch_gbe driver is a bit special as it relies on extra code in > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > > drivers/ptp/ even if PTP_1588_CLOCK is unselected. > > The

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Nicolas Pitre
On Thu, 20 Oct 2016, Richard Cochran wrote: > On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > > +static inline void ptp_clock_event(struct ptp_clock *ptp, > > + struct ptp_clock_event *event) > > +{ (void)event; } > > Just out of curiosity, why do

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Nicolas Pitre
On Thu, 20 Oct 2016, Richard Cochran wrote: > On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > > +static inline void ptp_clock_event(struct ptp_clock *ptp, > > + struct ptp_clock_event *event) > > +{ (void)event; } > > Just out of curiosity, why do

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Josh Triplett
On Thu, Oct 20, 2016 at 04:06:02PM +0200, Richard Cochran wrote: > On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > > +static inline void ptp_clock_event(struct ptp_clock *ptp, > > + struct ptp_clock_event *event) > > +{ (void)event; } > > Just out of

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Josh Triplett
On Thu, Oct 20, 2016 at 04:06:02PM +0200, Richard Cochran wrote: > On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > > +static inline void ptp_clock_event(struct ptp_clock *ptp, > > + struct ptp_clock_event *event) > > +{ (void)event; } > > Just out of

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Richard Cochran
On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > +static inline void ptp_clock_event(struct ptp_clock *ptp, > +struct ptp_clock_event *event) > +{ (void)event; } Just out of curiosity, why do you need that cast? (I thought the kernel's gcc settings

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Richard Cochran
On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > +static inline void ptp_clock_event(struct ptp_clock *ptp, > +struct ptp_clock_event *event) > +{ (void)event; } Just out of curiosity, why do you need that cast? (I thought the kernel's gcc settings

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Thomas Gleixner
On Wed, 19 Oct 2016, Nicolas Pitre wrote: > The pch_gbe driver is a bit special as it relies on extra code in > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > drivers/ptp/ even if PTP_1588_CLOCK is unselected. The above paragraph looks like a leftover of the previous

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-20 Thread Thomas Gleixner
On Wed, 19 Oct 2016, Nicolas Pitre wrote: > The pch_gbe driver is a bit special as it relies on extra code in > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > drivers/ptp/ even if PTP_1588_CLOCK is unselected. The above paragraph looks like a leftover of the previous

[PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-19 Thread Nicolas Pitre
In order to break the hard dependency between the PTP clock subsystem and ethernet drivers capable of being clock providers, this patch provides simple PTP stub functions to allow linkage of those drivers into the kernel even when the PTP subsystem is configured out. Drivers must be ready to

[PATCH 3/4] ptp_clock: allow for it to be optional

2016-10-19 Thread Nicolas Pitre
In order to break the hard dependency between the PTP clock subsystem and ethernet drivers capable of being clock providers, this patch provides simple PTP stub functions to allow linkage of those drivers into the kernel even when the PTP subsystem is configured out. Drivers must be ready to