Re: [PATCH 3/4] selftests/seccomp: Refactor RET_ERRNO tests

2017-08-07 Thread Tyler Hicks
On 08/02/2017 10:19 PM, Kees Cook wrote: > This refactors the errno tests (since they all use the same pattern for > their filter) and adds a RET_DATA field ordering test. > > Signed-off-by: Kees Cook This all looks good and is a great idea. Reviewed-by: Tyler Hicks

Re: [PATCH 3/4] selftests/seccomp: Refactor RET_ERRNO tests

2017-08-07 Thread Tyler Hicks
On 08/02/2017 10:19 PM, Kees Cook wrote: > This refactors the errno tests (since they all use the same pattern for > their filter) and adds a RET_DATA field ordering test. > > Signed-off-by: Kees Cook This all looks good and is a great idea. Reviewed-by: Tyler Hicks Tyler > --- >

[PATCH 3/4] selftests/seccomp: Refactor RET_ERRNO tests

2017-08-02 Thread Kees Cook
This refactors the errno tests (since they all use the same pattern for their filter) and adds a RET_DATA field ordering test. Signed-off-by: Kees Cook --- tools/testing/selftests/seccomp/seccomp_bpf.c | 95 --- 1 file changed, 58 insertions(+), 37

[PATCH 3/4] selftests/seccomp: Refactor RET_ERRNO tests

2017-08-02 Thread Kees Cook
This refactors the errno tests (since they all use the same pattern for their filter) and adds a RET_DATA field ordering test. Signed-off-by: Kees Cook --- tools/testing/selftests/seccomp/seccomp_bpf.c | 95 --- 1 file changed, 58 insertions(+), 37 deletions(-) diff