在 2021/1/25 15:55, Richard Weinberger 写道:
The idea was that in the !whiteout case, sz_change is always 0.
Oh, sz_change was initialized to 0, I missed it.
Thanks.
On Mon, Jan 25, 2021 at 2:12 AM Zhihao Cheng wrote:
>
> 在 2021/1/23 10:45, Zhihao Cheng 写道:
>
> >> @@ -430,6 +433,7 @@ static int do_tmpfile(struct inode *dir, struct
> >> dentry *dentry,
> >> return 0;
> >> out_cancel:
> Still one question:
> > Does this need a judgment? Like this,
The
在 2021/1/23 10:45, Zhihao Cheng 写道:
@@ -430,6 +433,7 @@ static int do_tmpfile(struct inode *dir, struct
dentry *dentry,
return 0;
out_cancel:
Still one question:
Does this need a judgment? Like this,
if (whiteout)
dir->i_size -= sz_change;
+ dir->i_size -= sz_change;
- Ursprüngliche Mail -
> Von: "chengzhihao1"
> An: "richard" , "linux-mtd"
> CC: "david" , "linux-kernel"
> , "stable"
> Gesendet: Samstag, 23. Januar 2021 03:45:15
> Betreff: Re: [PATCH 3/4] ubifs: Update di
在 2021/1/23 5:22, Richard Weinberger 写道:
Although whiteouts are unlinked files they will get re-linked later,
I just want to make sure, is this where the count is increased?
do_rename -> inc_nlink(whiteout)
therefore the size of the parent directory needs to be updated too.
Cc:
Although whiteouts are unlinked files they will get re-linked later,
therefore the size of the parent directory needs to be updated too.
Cc: sta...@vger.kernel.org
Fixes: 9e0a1fff8db5 ("ubifs: Implement RENAME_WHITEOUT")
Signed-off-by: Richard Weinberger
---
fs/ubifs/dir.c | 4
1 file
6 matches
Mail list logo
