Re: [PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr()

2012-10-06 Thread Srikar Dronamraju
* Oleg Nesterov [2012-09-23 22:19:50]: > Unlike set_swbp(), set_orig_insn()->is_swbp_at_addr() makes sense, > although it can't prevent all confusions. > > But the usage of is_swbp_at_addr() is equally confusing, and it adds > the extra get_user_pages() we can avoid. > > This patch removes set_

Re: [PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr()

2012-09-24 Thread Oleg Nesterov
On 09/24, Peter Zijlstra wrote: > > On Sun, 2012-09-23 at 22:19 +0200, Oleg Nesterov wrote: > > > @@ -226,6 +245,10 @@ retry: > > Could you use: > > $ cat ~/.gitconfig > [diff "default"] > xfuncname = "^[[:alpha:]$_].*[^:]$" > > This avoids git-diff it using labels as function names. Aha. Wi

Re: [PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr()

2012-09-24 Thread Peter Zijlstra
On Sun, 2012-09-23 at 22:19 +0200, Oleg Nesterov wrote: > @@ -226,6 +245,10 @@ retry: Could you use: $ cat ~/.gitconfig [diff "default"] xfuncname = "^[[:alpha:]$_].*[^:]$" This avoids git-diff it using labels as function names. > if (ret <= 0) > return ret; > >

[PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr()

2012-09-23 Thread Oleg Nesterov
Unlike set_swbp(), set_orig_insn()->is_swbp_at_addr() makes sense, although it can't prevent all confusions. But the usage of is_swbp_at_addr() is equally confusing, and it adds the extra get_user_pages() we can avoid. This patch removes set_orig_insn()->is_swbp_at_addr() but changes write_opcode