Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req

2021-01-04 Thread Greg Kroah-Hartman
On Mon, Jan 04, 2021 at 03:08:13PM +0100, Jerome Brunet wrote: > > On Tue 29 Dec 2020 at 23:30, Jack Pham wrote: > > > Hi Greg and Jerome, > > > > On Mon, Dec 28, 2020 at 04:01:46PM +0100, Greg Kroah-Hartman wrote: > >> On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote: > >> >

Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req

2021-01-04 Thread Jerome Brunet
On Tue 29 Dec 2020 at 23:30, Jack Pham wrote: > Hi Greg and Jerome, > > On Mon, Dec 28, 2020 at 04:01:46PM +0100, Greg Kroah-Hartman wrote: >> On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote: >> > 'struct uac_req' purpose is to link 'struct usb_request' to the >> > corresponding

Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req

2020-12-29 Thread Jack Pham
Hi Greg and Jerome, On Mon, Dec 28, 2020 at 04:01:46PM +0100, Greg Kroah-Hartman wrote: > On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote: > > 'struct uac_req' purpose is to link 'struct usb_request' to the > > corresponding 'struct uac_rtd_params'. However member req is never > >

Re: [PATCH 3/4] usb: gadget: u_audio: remove struct uac_req

2020-12-28 Thread Greg Kroah-Hartman
On Mon, Dec 21, 2020 at 06:35:30PM +0100, Jerome Brunet wrote: > 'struct uac_req' purpose is to link 'struct usb_request' to the > corresponding 'struct uac_rtd_params'. However member req is never > used. Using the context of the usb request, we can keep track of the > corresponding 'struct

[PATCH 3/4] usb: gadget: u_audio: remove struct uac_req

2020-12-21 Thread Jerome Brunet
'struct uac_req' purpose is to link 'struct usb_request' to the corresponding 'struct uac_rtd_params'. However member req is never used. Using the context of the usb request, we can keep track of the corresponding 'struct uac_rtd_params' just as well, without allocating extra memory.