Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Guenter Roeck
On 01/03/2017 03:50 PM, Andy Shevchenko wrote: On Wed, Jan 4, 2017 at 1:48 AM, Andy Shevchenko wrote: On Wed, Jan 4, 2017 at 1:40 AM, Guenter Roeck wrote: On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote: On Tue, Jan 3, 2017 at

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Guenter Roeck
On 01/03/2017 03:50 PM, Andy Shevchenko wrote: On Wed, Jan 4, 2017 at 1:48 AM, Andy Shevchenko wrote: On Wed, Jan 4, 2017 at 1:40 AM, Guenter Roeck wrote: On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote: On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: Use pdev for

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Andy Shevchenko
On Wed, Jan 4, 2017 at 1:48 AM, Andy Shevchenko wrote: > On Wed, Jan 4, 2017 at 1:40 AM, Guenter Roeck wrote: >> On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote: >>> On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Andy Shevchenko
On Wed, Jan 4, 2017 at 1:48 AM, Andy Shevchenko wrote: > On Wed, Jan 4, 2017 at 1:40 AM, Guenter Roeck wrote: >> On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote: >>> On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: >>> > Use pdev for struct platform_device, pcidev for struct

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Andy Shevchenko
On Wed, Jan 4, 2017 at 1:40 AM, Guenter Roeck wrote: > On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote: >> On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: >> > Use pdev for struct platform_device, pcidev for struct pci_dev, and dev >>

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Andy Shevchenko
On Wed, Jan 4, 2017 at 1:40 AM, Guenter Roeck wrote: > On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote: >> On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: >> > Use pdev for struct platform_device, pcidev for struct pci_dev, and dev >> > for struct device variables to improve

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Guenter Roeck
On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote: > On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: > > Use pdev for struct platform_device, pcidev for struct pci_dev, and dev > > for struct device variables to improve consistency. > > > > Remove 'struct

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Guenter Roeck
On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote: > On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: > > Use pdev for struct platform_device, pcidev for struct pci_dev, and dev > > for struct device variables to improve consistency. > > > > Remove 'struct platform_device *dev;'

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Andy Shevchenko
On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: > Use pdev for struct platform_device, pcidev for struct pci_dev, and dev > for struct device variables to improve consistency. > > Remove 'struct platform_device *dev;' from struct iTCO_wdt_private since > it was unused.

Re: [PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Andy Shevchenko
On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck wrote: > Use pdev for struct platform_device, pcidev for struct pci_dev, and dev > for struct device variables to improve consistency. > > Remove 'struct platform_device *dev;' from struct iTCO_wdt_private since > it was unused. Would pci_dev work?

[PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Guenter Roeck
Use pdev for struct platform_device, pcidev for struct pci_dev, and dev for struct device variables to improve consistency. Remove 'struct platform_device *dev;' from struct iTCO_wdt_private since it was unused. Signed-off-by: Guenter Roeck --- drivers/watchdog/iTCO_wdt.c |

[PATCH 3/4] watchdog: iTCO_wdt: Use pdev for platform device and pci_dev for pci device

2017-01-03 Thread Guenter Roeck
Use pdev for struct platform_device, pcidev for struct pci_dev, and dev for struct device variables to improve consistency. Remove 'struct platform_device *dev;' from struct iTCO_wdt_private since it was unused. Signed-off-by: Guenter Roeck --- drivers/watchdog/iTCO_wdt.c | 53