Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-12-13 Thread Cyrille Pitchen
Hi all, Le 06/12/2017 à 12:32, Lorenzo Pieralisi a écrit : > On Mon, Dec 04, 2017 at 06:49:12PM +, Ard Biesheuvel wrote: > > [...] > >> +static int cdns_pcie_host_init_root_port(struct cdns_pcie_rc *rc) >> +{ >> + const struct cdns_pcie_rc_data *data = rc->data; >> +

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-12-06 Thread Lorenzo Pieralisi
On Mon, Dec 04, 2017 at 06:49:12PM +, Ard Biesheuvel wrote: [...] > >> >> +static int cdns_pcie_host_init_root_port(struct cdns_pcie_rc *rc) > >> >> +{ > >> >> + const struct cdns_pcie_rc_data *data = rc->data; > >> >> + struct cdns_pcie *pcie = &rc->pcie; > >> >> + u8 pbn, sbn, s

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-12-04 Thread Ard Biesheuvel
On 4 December 2017 at 18:20, Lorenzo Pieralisi wrote: > [+Ard] > > Hi Cyrille, > > On Sun, Dec 03, 2017 at 09:44:46PM +0100, Cyrille Pitchen wrote: > > [...] > >> >> +cdns_pci_map_bus(struct pci_bus *bus, unsigned int devfn, int where) >> >> +{ >> >> + struct pci_host_bridge *bridge = pci_find

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-12-04 Thread Lorenzo Pieralisi
[+Ard] Hi Cyrille, On Sun, Dec 03, 2017 at 09:44:46PM +0100, Cyrille Pitchen wrote: [...] > >> +cdns_pci_map_bus(struct pci_bus *bus, unsigned int devfn, int where) > >> +{ > >> + struct pci_host_bridge *bridge = pci_find_host_bridge(bus); > >> + struct cdns_pcie_rc *rc = pci_host_bridg

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-12-03 Thread Cyrille Pitchen
Hi Lorenzo, Le 29/11/2017 à 18:34, Lorenzo Pieralisi a écrit : > On Thu, Nov 23, 2017 at 04:01:48PM +0100, Cyrille Pitchen wrote: >> This patch adds support to the Cadence PCIe controller in host mode. > > Bjorn already commented on this, it would be good to add some > of the cover letter details

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-12-01 Thread Lorenzo Pieralisi
On Fri, Dec 01, 2017 at 11:37:49AM +0100, Cyrille Pitchen wrote: > Hi Bjorn, > > Le 28/11/2017 à 21:41, Bjorn Helgaas a écrit : > > On Thu, Nov 23, 2017 at 04:01:48PM +0100, Cyrille Pitchen wrote: > >> This patch adds support to the Cadence PCIe controller in host mode. > >> > >> Signed-off-by: Cy

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-12-01 Thread Cyrille Pitchen
Hi Bjorn, Le 28/11/2017 à 21:41, Bjorn Helgaas a écrit : > On Thu, Nov 23, 2017 at 04:01:48PM +0100, Cyrille Pitchen wrote: >> This patch adds support to the Cadence PCIe controller in host mode. >> >> Signed-off-by: Cyrille Pitchen >> --- >> drivers/Makefile| 1 + >> d

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-30 Thread Lorenzo Pieralisi
On Wed, Nov 29, 2017 at 06:25:15PM +, Lorenzo Pieralisi wrote: [...] > static void __iomem *cdns_pci_map_bus(struct pci_bus *bus, unsigned int devfn, > int where) > > > +cdns_pci_map_bus(struct pci_bus *bus, unsigned int devfn, int where) > > +{ > > + st

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-29 Thread Lorenzo Pieralisi
[w/o unintended disclaimer] On Thu, Nov 23, 2017 at 04:01:48PM +0100, Cyrille Pitchen wrote: > This patch adds support to the Cadence PCIe controller in host mode. Bjorn already commented on this, it would be good to add some of the cover letter details in this log. > Signed-off-by: Cyrille Pitc

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-29 Thread Lorenzo Pieralisi
On Thu, Nov 23, 2017 at 04:01:48PM +0100, Cyrille Pitchen wrote: > This patch adds support to the Cadence PCIe controller in host mode. Bjorn already commented on this, it would be good to add some of the cover letter details in this log. > Signed-off-by: Cyrille Pitchen > --- > drivers/Makefil

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-29 Thread Bjorn Helgaas
On Wed, Nov 29, 2017 at 09:19:29AM +0100, Thomas Petazzoni wrote: > Hello, > > On Tue, 28 Nov 2017 14:41:14 -0600, Bjorn Helgaas wrote: > > > > + * struct cdns_pcie_rc_data - hardware specific data > > > > "cdns" is a weird abbreviation for "Cadence", since "Cadence" doesn't > > contain an "s"

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-29 Thread Lorenzo Pieralisi
On Tue, Nov 28, 2017 at 02:41:14PM -0600, Bjorn Helgaas wrote: [...] > > +static int cdns_pcie_parse_request_of_pci_ranges(struct device *dev, > > +struct list_head *resources, > > +struct resource **bus_range

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-29 Thread Thomas Petazzoni
Hello, On Tue, 28 Nov 2017 14:41:14 -0600, Bjorn Helgaas wrote: > > + * struct cdns_pcie_rc_data - hardware specific data > > "cdns" is a weird abbreviation for "Cadence", since "Cadence" doesn't > contain an "s". cdns is the official Device Tree binding vendor prefix for Cadence: $ grep Cad

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-28 Thread Bjorn Helgaas
On Tue, Nov 28, 2017 at 02:41:14PM -0600, Bjorn Helgaas wrote: > On Thu, Nov 23, 2017 at 04:01:48PM +0100, Cyrille Pitchen wrote: > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 1d034b680431..27bdd98784d9 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -18,6 +18,7

Re: [PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-28 Thread Bjorn Helgaas
On Thu, Nov 23, 2017 at 04:01:48PM +0100, Cyrille Pitchen wrote: > This patch adds support to the Cadence PCIe controller in host mode. > > Signed-off-by: Cyrille Pitchen > --- > drivers/Makefile| 1 + > drivers/pci/Kconfig | 1 + > drivers/pci/cad

[PATCH 3/5] PCI: cadence: Add host driver for Cadence PCIe controller

2017-11-23 Thread Cyrille Pitchen
This patch adds support to the Cadence PCIe controller in host mode. Signed-off-by: Cyrille Pitchen --- drivers/Makefile| 1 + drivers/pci/Kconfig | 1 + drivers/pci/cadence/Kconfig | 24 ++ drivers/pci/cadence/Makefile|