Re: [PATCH 3/5] block: nvme-core: simplify ida usage

2015-10-08 Thread Keith Busch
On Fri, 2 Oct 2015, Johannes Thumshirn wrote: Lee Duncan writes: Simplify ida index allocation and removal by using the ida_simple_* helper functions. Looks good to me. Just one comment: static void nvme_release_instance(struct nvme_dev *dev) { spin_lock(&dev_list_lock); - i

Re: [PATCH 3/5] block: nvme-core: simplify ida usage

2015-10-02 Thread Johannes Thumshirn
Lee Duncan writes: > Simplify ida index allocation and removal by > using the ida_simple_* helper functions. > > Signed-off-by: Lee Duncan > --- > drivers/block/nvme-core.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/block/nvme-core.c b/dri

[PATCH 3/5] block: nvme-core: simplify ida usage

2015-10-01 Thread Lee Duncan
Simplify ida index allocation and removal by using the ida_simple_* helper functions. Signed-off-by: Lee Duncan --- drivers/block/nvme-core.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index d1d61419