Re: [PATCH 3/5] fpga manager: xilinx-spi: remove unneeded, mistyped variables

2020-06-18 Thread Moritz Fischer
On Thu, Jun 11, 2020 at 11:11:42PM +0200, Luca Ceresoli wrote: > Using variables does not add readability here: parameters passed > to udelay*() are obviously in microseconds and their meaning is clear > from the context. > > The type is also wrong, udelay expects an unsigned long. > >

[PATCH 3/5] fpga manager: xilinx-spi: remove unneeded, mistyped variables

2020-06-11 Thread Luca Ceresoli
Using variables does not add readability here: parameters passed to udelay*() are obviously in microseconds and their meaning is clear from the context. The type is also wrong, udelay expects an unsigned long. Signed-off-by: Luca Ceresoli --- drivers/fpga/xilinx-spi.c | 6 ++ 1 file