[PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit

2014-04-10 Thread Luiz Capitulino
Hugepages pages never get the PG_reserved bit set, so don't clear it. However, note that if the bit gets mistakenly set free_pages_check() will catch it. Signed-off-by: Luiz Capitulino --- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c

[PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit

2014-04-10 Thread Luiz Capitulino
Hugepages pages never get the PG_reserved bit set, so don't clear it. However, note that if the bit gets mistakenly set free_pages_check() will catch it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit

2014-04-08 Thread Luiz Capitulino
On Tue, 8 Apr 2014 23:51:26 +0300 "Kirill A. Shutemov" wrote: > On Tue, Apr 08, 2014 at 03:02:18PM -0400, Luiz Capitulino wrote: > > Hugepages pages never get the PG_reserved bit set, so don't clear it. But > > add a warning just in case. > > I don't think WARN_ON() is needed. PG_reserved will

Re: [PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit

2014-04-08 Thread Kirill A. Shutemov
On Tue, Apr 08, 2014 at 03:02:18PM -0400, Luiz Capitulino wrote: > Hugepages pages never get the PG_reserved bit set, so don't clear it. But > add a warning just in case. I don't think WARN_ON() is needed. PG_reserved will be catched by free_pages_check(). -- Kirill A. Shutemov -- To

[PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit

2014-04-08 Thread Luiz Capitulino
Hugepages pages never get the PG_reserved bit set, so don't clear it. But add a warning just in case. Signed-off-by: Luiz Capitulino Reviewed-by: Andrea Arcangeli Reviewed-by: Naoya Horiguchi Reviewed-by: Yasuaki Ishimatsu --- mm/hugetlb.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit

2014-04-08 Thread Luiz Capitulino
Hugepages pages never get the PG_reserved bit set, so don't clear it. But add a warning just in case. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Andrea Arcangeli aarca...@redhat.com Reviewed-by: Naoya Horiguchi n-horigu...@ah.jp.nec.com Reviewed-by: Yasuaki Ishimatsu

Re: [PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit

2014-04-08 Thread Kirill A. Shutemov
On Tue, Apr 08, 2014 at 03:02:18PM -0400, Luiz Capitulino wrote: Hugepages pages never get the PG_reserved bit set, so don't clear it. But add a warning just in case. I don't think WARN_ON() is needed. PG_reserved will be catched by free_pages_check(). -- Kirill A. Shutemov -- To unsubscribe

Re: [PATCH 3/5] hugetlb: update_and_free_page(): don't clear PG_reserved bit

2014-04-08 Thread Luiz Capitulino
On Tue, 8 Apr 2014 23:51:26 +0300 Kirill A. Shutemov kir...@shutemov.name wrote: On Tue, Apr 08, 2014 at 03:02:18PM -0400, Luiz Capitulino wrote: Hugepages pages never get the PG_reserved bit set, so don't clear it. But add a warning just in case. I don't think WARN_ON() is needed.