Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-23 Thread Wolfram Sang
> Yes the STM32F7 has a new I2C IP core compared to STM32F4. > The engine, the machine state are very different. > I tried few months ago to write a common driver but it was very very > difficilcut as the 2 IP are not so much things in common. Good, thanks for the heads up! signature.asc Descr

Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-23 Thread M'boumba Cedric Madianga
Hi Wolfram, Yes the STM32F7 has a new I2C IP core compared to STM32F4. The engine, the machine state are very different. I tried few months ago to write a common driver but it was very very difficilcut as the 2 IP are not so much things in common. BR, Cedric 2017-03-23 21:17 GMT+01:00 Wolfram Sa

Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-23 Thread Wolfram Sang
On Fri, Mar 17, 2017 at 10:58:56AM +0100, M'boumba Cedric Madianga wrote: > This patch adds initial support for the STM32F7 I2C controller. > > Signed-off-by: M'boumba Cedric Madianga So, the STM32F7 has a new I2C IP core compared to STM32F4? signature.asc Description: PGP signature

Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-17 Thread M'boumba Cedric Madianga
Hi Neil, >> As, I2C rise/fall time have some impacts in I2C timings value, the >> question is: it is very relevant to let customer control these >> parameters ? > > Actually, you could specify a different rise time in DT if it's relevant for > a specific design, this is why you have the following

Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-17 Thread Neil Armstrong
Hi Cedric, On 03/17/2017 04:35 PM, M'boumba Cedric Madianga wrote: >> Sorry I don't understand. >> The value you use from the DT and the one calculated from the >> setup/hold/high/low value >> with the algorithm I developed will set the same values. > > With the ST tool, I could set the followin

Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-17 Thread M'boumba Cedric Madianga
> Sorry I don't understand. > The value you use from the DT and the one calculated from the > setup/hold/high/low value > with the algorithm I developed will set the same values. With the ST tool, I could set the following values: I2C speed mode (Master, Fast Mode, Fast Mode Plus) I2C speed frequ

Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-17 Thread Neil Armstrong
On 03/17/2017 02:52 PM, M'boumba Cedric Madianga wrote: > Hi, > > >>> +static int stm32f7_i2c_hw_config(struct stm32f7_i2c_dev *i2c_dev) >>> +{ >>> + struct device_node *of_node = i2c_dev->dev->of_node; >>> + u32 timing; >>> + int ret; >>> + >>> + ret = of_property_read_u32(of_nod

Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-17 Thread M'boumba Cedric Madianga
Hi, >> +static int stm32f7_i2c_hw_config(struct stm32f7_i2c_dev *i2c_dev) >> +{ >> + struct device_node *of_node = i2c_dev->dev->of_node; >> + u32 timing; >> + int ret; >> + >> + ret = of_property_read_u32(of_node, "st,i2c-timing", &timing); >> + if (ret) { >> + de

Re: [PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-17 Thread Neil Armstrong
On 03/17/2017 10:58 AM, M'boumba Cedric Madianga wrote: > This patch adds initial support for the STM32F7 I2C controller. > > Signed-off-by: M'boumba Cedric Madianga > --- > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-stm32f7.c |

[PATCH 3/5] i2c: i2c-stm32f7: add driver

2017-03-17 Thread M'boumba Cedric Madianga
This patch adds initial support for the STM32F7 I2C controller. Signed-off-by: M'boumba Cedric Madianga --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-stm32f7.c | 562 +++ 3 files changed, 573 ins