Re: [PATCH 3/5] mfd: sec: Remove sec_reg* regmap helpers

2013-12-18 Thread Mark Brown
On Wed, Dec 18, 2013 at 03:03:51PM +0100, Krzysztof Kozlowski wrote: > On Wed, 2013-12-18 at 13:36 +, Mark Brown wrote: > > This doesn't apply against the regulator tree. Can you please check > > what's going on here, I guess there may need to be some merge with MFD? > I think you need to re

Re: [PATCH 3/5] mfd: sec: Remove sec_reg* regmap helpers

2013-12-18 Thread Krzysztof Kozlowski
On Wed, 2013-12-18 at 13:36 +, Mark Brown wrote: > On Tue, Dec 17, 2013 at 02:23:19PM +0100, Krzysztof Kozlowski wrote: > > Remove sec_reg* helpers as they are not used anymore. These helpers were > > error-prone as they mixed u8 with unsigned int and they changed order of > > some of parameter

Re: [PATCH 3/5] mfd: sec: Remove sec_reg* regmap helpers

2013-12-18 Thread Mark Brown
On Tue, Dec 17, 2013 at 02:23:19PM +0100, Krzysztof Kozlowski wrote: > Remove sec_reg* helpers as they are not used anymore. These helpers were > error-prone as they mixed u8 with unsigned int and they changed order of > some of parameters (val and mask in sec_reg_update()). This doesn't apply aga

[PATCH 3/5] mfd: sec: Remove sec_reg* regmap helpers

2013-12-17 Thread Krzysztof Kozlowski
Remove sec_reg* helpers as they are not used anymore. These helpers were error-prone as they mixed u8 with unsigned int and they changed order of some of parameters (val and mask in sec_reg_update()). Also the helpers didn't give any way of useful abstraction as they just called corresponding regm