Re: [PATCH 3/5] net: Set fput_needed iff FDPUT_FPUT is set

2020-08-08 Thread David Miller
From: linmiaohe Date: Thu, 6 Aug 2020 19:53:16 +0800 > From: Miaohe Lin > > We should fput() file iff FDPUT_FPUT is set. So we should set fput_needed > accordingly. > > Fixes: 00e188ef6a7e ("sockfd_lookup_light(): switch to fdget^W^Waway from > fget_light") > Signed-off-by: Miaohe Lin

Re: [PATCH 3/5] net: Set fput_needed iff FDPUT_FPUT is set

2020-08-07 Thread linmiaohe
Al Viro wrote: >On Thu, Aug 06, 2020 at 12:59:16PM +0100, Al Viro wrote: >> On Thu, Aug 06, 2020 at 07:53:16PM +0800, linmiaohe wrote: >> > From: Miaohe Lin >> > >> > We should fput() file iff FDPUT_FPUT is set. So we should set >> > fput_needed accordingly. >> > >> > Fixes: 00e188ef6a7e

[PATCH 3/5] net: Set fput_needed iff FDPUT_FPUT is set

2020-08-06 Thread linmiaohe
From: Miaohe Lin We should fput() file iff FDPUT_FPUT is set. So we should set fput_needed accordingly. Fixes: 00e188ef6a7e ("sockfd_lookup_light(): switch to fdget^W^Waway from fget_light") Signed-off-by: Miaohe Lin --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 3/5] net: Set fput_needed iff FDPUT_FPUT is set

2020-08-06 Thread Al Viro
On Thu, Aug 06, 2020 at 12:59:16PM +0100, Al Viro wrote: > On Thu, Aug 06, 2020 at 07:53:16PM +0800, linmiaohe wrote: > > From: Miaohe Lin > > > > We should fput() file iff FDPUT_FPUT is set. So we should set fput_needed > > accordingly. > > > > Fixes: 00e188ef6a7e ("sockfd_lookup_light():

Re: [PATCH 3/5] net: Set fput_needed iff FDPUT_FPUT is set

2020-08-06 Thread Al Viro
On Thu, Aug 06, 2020 at 07:53:16PM +0800, linmiaohe wrote: > From: Miaohe Lin > > We should fput() file iff FDPUT_FPUT is set. So we should set fput_needed > accordingly. > > Fixes: 00e188ef6a7e ("sockfd_lookup_light(): switch to fdget^W^Waway from > fget_light") Explain, please. We are