Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-15 Thread Michal Hocko
On Sat 06-02-16 20:23:43, Tetsuo Handa wrote: > Michal Hocko wrote: [...] > By always waking the OOM reaper up, we can delegate the duty of unlocking > the OOM killer (by clearing TIF_MEMDIE or some other means) to the OOM > reaper because the OOM reaper is tracking all TIF_MEMDIE tasks. And again

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-06 Thread Tetsuo Handa
Michal Hocko wrote: > On Thu 04-02-16 15:43:19, Michal Hocko wrote: > > On Thu 04-02-16 23:22:18, Tetsuo Handa wrote: > > > Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > > When oom_reaper manages to unmap all the eligible vmas there shouldn't > > > > be much of the freable memory h

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-06 Thread Tetsuo Handa
Michal Hocko wrote: > I am not really sure I understand what you are trying to tell here to be > honest > but no I am not going to add any timers at this stage. > Dropping TIF_MEMDIE will help to unlock OOM killer as soon as we know > the current victim is no longer interesting for the OOM killer

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-06 Thread Michal Hocko
On Fri 05-02-16 20:14:40, Tetsuo Handa wrote: > Michal Hocko wrote: > > On Fri 05-02-16 00:08:25, Tetsuo Handa wrote: > > > Michal Hocko wrote: > > > > > > + /* > > > > > > +* Clear TIF_MEMDIE because the task shouldn't be sitting on a > > > > > > +* reasonably reclaimable memory anymore.

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-05 Thread Michal Hocko
On Thu 04-02-16 15:43:19, Michal Hocko wrote: > On Thu 04-02-16 23:22:18, Tetsuo Handa wrote: > > Michal Hocko wrote: > > > From: Michal Hocko > > > > > > When oom_reaper manages to unmap all the eligible vmas there shouldn't > > > be much of the freable memory held by the oom victim left anymore

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-05 Thread Tetsuo Handa
Michal Hocko wrote: > On Fri 05-02-16 00:08:25, Tetsuo Handa wrote: > > Michal Hocko wrote: > > > > > + /* > > > > > + * Clear TIF_MEMDIE because the task shouldn't be sitting on a > > > > > + * reasonably reclaimable memory anymore. OOM killer can > > > > > continue > > > > > +

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-04 Thread Michal Hocko
On Fri 05-02-16 00:08:25, Tetsuo Handa wrote: > Michal Hocko wrote: > > > > + /* > > > > +* Clear TIF_MEMDIE because the task shouldn't be sitting on a > > > > +* reasonably reclaimable memory anymore. OOM killer can > > > > continue > > > > +* by selecting other vict

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-04 Thread Tetsuo Handa
Michal Hocko wrote: > > > + /* > > > + * Clear TIF_MEMDIE because the task shouldn't be sitting on a > > > + * reasonably reclaimable memory anymore. OOM killer can continue > > > + * by selecting other victim if unmapping hasn't led to any > > > + * improvements. This also means that selecting

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-04 Thread Michal Hocko
On Thu 04-02-16 23:22:18, Tetsuo Handa wrote: > Michal Hocko wrote: > > From: Michal Hocko > > > > When oom_reaper manages to unmap all the eligible vmas there shouldn't > > be much of the freable memory held by the oom victim left anymore so it > > makes sense to clear the TIF_MEMDIE flag for th

Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-04 Thread Tetsuo Handa
Michal Hocko wrote: > From: Michal Hocko > > When oom_reaper manages to unmap all the eligible vmas there shouldn't > be much of the freable memory held by the oom victim left anymore so it > makes sense to clear the TIF_MEMDIE flag for the victim and allow the > OOM killer to select another task

[PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space

2016-02-03 Thread Michal Hocko
From: Michal Hocko When oom_reaper manages to unmap all the eligible vmas there shouldn't be much of the freable memory held by the oom victim left anymore so it makes sense to clear the TIF_MEMDIE flag for the victim and allow the OOM killer to select another task. The lack of TIF_MEMDIE also m