Re: [PATCH 3/5] perf hists: Link hist entries before inserting to an output tree

2012-12-07 Thread Namhyung Kim
Hi, On Thu, 6 Dec 2012 17:25:43 +0100, Jiri Olsa wrote: > On Fri, Dec 07, 2012 at 12:09:39AM +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> For matching and/or linking hist entries, they need to be sorted by >> given sort keys. However current hists__match/link did this on the >> output

Re: [PATCH 3/5] perf hists: Link hist entries before inserting to an output tree

2012-12-06 Thread Jiri Olsa
On Fri, Dec 07, 2012 at 12:09:39AM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > For matching and/or linking hist entries, they need to be sorted by > given sort keys. However current hists__match/link did this on the > output trees, so that the entries in the output tree need to be resort

[PATCH 3/5] perf hists: Link hist entries before inserting to an output tree

2012-12-06 Thread Namhyung Kim
From: Namhyung Kim For matching and/or linking hist entries, they need to be sorted by given sort keys. However current hists__match/link did this on the output trees, so that the entries in the output tree need to be resort before doing it. This looks not so good since we have trees for collec