Re: [PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names

2018-01-15 Thread Dmitry Safonov
On Mon, 2018-01-15 at 13:09 -0500, David Miller wrote: > From: Dmitry Safonov > Date: Tue, 9 Jan 2018 13:55:33 + > > > +#define pf(flag) __stringify(flag), > > +char *pkt_flag_names[] = { > > + PKT_FLAGS > > +}; > > +#undef pf > > This should be static, also you don't use th

Re: [PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names

2018-01-15 Thread David Miller
From: Dmitry Safonov Date: Tue, 9 Jan 2018 13:55:33 + > +#define pf(flag) __stringify(flag), > +char *pkt_flag_names[] = { > + PKT_FLAGS > +}; > +#undef pf This should be static, also you don't use this table in this patch. You should add the table in the patch that actuall

[PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names

2018-01-09 Thread Dmitry Safonov
The array will be used to simplify the code that prints/reads pkg flags. Sorted the array in order of printing the flags in pktgen_if_show() Note: Renamed IPSEC_ON => IPSEC for simplicity. No visible behavior change expected. Signed-off-by: Dmitry Safonov --- net/core/pktgen.c | 64