Re: [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core

2014-03-21 Thread Lee Jones
> It is more idiomatic to process things relating to the regulator in its > driver. This patch moves both processing of device tree relating to the > regulator and checking if the regulator is external from arizona-core > into the regulator driver. > > Signed-off-by: Charles Keepax > --- > drive

[PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core

2014-03-19 Thread Charles Keepax
It is more idiomatic to process things relating to the regulator in its driver. This patch moves both processing of device tree relating to the regulator and checking if the regulator is external from arizona-core into the regulator driver. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-c

Re: [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core

2014-03-19 Thread Charles Keepax
On Tue, Mar 18, 2014 at 05:44:30PM +, Mark Brown wrote: > On Tue, Mar 18, 2014 at 05:22:31PM +, Charles Keepax wrote: > > > - /* > > -* LDO1 can only be used to supply DCVDD so if it has no > > -* consumers then DCVDD is supplied externally. > > -*/ > > - if (arizona->pdata

Re: [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core

2014-03-18 Thread Mark Brown
On Tue, Mar 18, 2014 at 05:22:31PM +, Charles Keepax wrote: > - /* > - * LDO1 can only be used to supply DCVDD so if it has no > - * consumers then DCVDD is supplied externally. > - */ > - if (arizona->pdata.ldo1 && > - arizona->pdata.ldo1->num_consumer_supplies

[PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core

2014-03-18 Thread Charles Keepax
It is more idiomatic to process things relating to the regulator in its driver. This patch moves both processing of device tree relating to the regulator and checking if the regulator is external from arizona-core into the regulator driver. Signed-off-by: Charles Keepax --- drivers/mfd/arizona-c