Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

2014-08-16 Thread Mark Brown
On Fri, Jun 06, 2014 at 06:05:52PM +0200, Maxime Ripard wrote: > On Thu, Jun 05, 2014 at 04:49:31PM +0100, Mark Brown wrote: > > This sounds like you are passing the MFD child device into the regulator > > API when you should be passing the parent device in. > We're passing the device coming from

Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

2014-06-06 Thread Maxime Ripard
On Thu, Jun 05, 2014 at 04:49:31PM +0100, Mark Brown wrote: > On Thu, Jun 05, 2014 at 04:27:29PM +0200, Maxime Ripard wrote: > > > You already list the regulators available and their supply in the > > regulator driver, why do you need to set the regulator parents in the > > mfd driver as well? >

Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

2014-06-05 Thread Mark Brown
On Thu, Jun 05, 2014 at 04:27:29PM +0200, Maxime Ripard wrote: > You already list the regulators available and their supply in the > regulator driver, why do you need to set the regulator parents in the > mfd driver as well? Unless they're being used by the MFD directly there should be no need fo

Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

2014-06-05 Thread Maxime Ripard
On Tue, Jun 03, 2014 at 03:43:19PM +0100, Mark Brown wrote: > On Tue, Jun 03, 2014 at 03:12:04PM +0200, Maxime Ripard wrote: > > On Wed, May 28, 2014 at 07:50:51PM +0100, Mark Brown wrote: > > > On Wed, May 28, 2014 at 07:11:07PM +0200, Maxime Ripard wrote: > > > > > axp_mic_reg: l

Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

2014-06-03 Thread Mark Brown
On Tue, Jun 03, 2014 at 03:12:04PM +0200, Maxime Ripard wrote: > On Wed, May 28, 2014 at 07:50:51PM +0100, Mark Brown wrote: > > On Wed, May 28, 2014 at 07:11:07PM +0200, Maxime Ripard wrote: > > > axp_mic_reg: ldo5 { > > > + vin-supply = <&axp_ipsout_reg>; > > This is s

Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

2014-06-03 Thread Maxime Ripard
On Wed, May 28, 2014 at 07:50:51PM +0100, Mark Brown wrote: > On Wed, May 28, 2014 at 07:11:07PM +0200, Maxime Ripard wrote: > > > axp_vcore_reg: dcdc2 { > > + vin-supply = <&axp_ipsout_reg>; > > > axp_ddr_reg: dcdc3 { > > + vin-supply =

Re: [PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

2014-05-28 Thread Mark Brown
On Wed, May 28, 2014 at 07:11:07PM +0200, Maxime Ripard wrote: > axp_vcore_reg: dcdc2 { > + vin-supply = <&axp_ipsout_reg>; > axp_ddr_reg: dcdc3 { > + vin-supply = <&axp_ipsout_reg>; > axp_rtc_reg: ldo1 { > +

[PATCH 3/5] regulator: axp20x: Update the bindings to use a local parent regulator

2014-05-28 Thread Maxime Ripard
Since the regulator core is now able to handle parent regulators that are tied to the regulator nodes themselves instead of the parent device in the DT, update the bindings and the regulator code to use a vin-supply property for each regulator. Signed-off-by: Maxime Ripard --- Documentation/devi