Re: [PATCH 3/5] rtl8712: replace printk with better solutions

2012-12-09 Thread Joe Perches
On Sun, 2012-12-09 at 10:15 +, Przemo Firszt wrote: > Replace printk with netdev_printk helpers, dev_printk helpers or > pr_err/warn/info if there is no device info available. Here's a few trivial comments > @@ -84,8 +83,8 @@ static u32 rtl871x_open_fw(struct _adapter *padapter, const > u8

[PATCH 3/5] rtl8712: replace printk with better solutions

2012-12-09 Thread Przemo Firszt
Replace printk with netdev_printk helpers, dev_printk helpers or pr_err/warn/info if there is no device info available. Signed-off-by: Przemo Firszt --- drivers/staging/rtl8712/hal_init.c| 17 ++- drivers/staging/rtl8712/os_intfs.c| 3 +-

[PATCH 3/5] rtl8712: replace printk with better solutions

2012-12-09 Thread Przemo Firszt
Replace printk with netdev_printk helpers, dev_printk helpers or pr_err/warn/info if there is no device info available. Signed-off-by: Przemo Firszt prz...@firszt.eu --- drivers/staging/rtl8712/hal_init.c| 17 ++- drivers/staging/rtl8712/os_intfs.c| 3 +-

Re: [PATCH 3/5] rtl8712: replace printk with better solutions

2012-12-09 Thread Joe Perches
On Sun, 2012-12-09 at 10:15 +, Przemo Firszt wrote: Replace printk with netdev_printk helpers, dev_printk helpers or pr_err/warn/info if there is no device info available. Here's a few trivial comments @@ -84,8 +83,8 @@ static u32 rtl871x_open_fw(struct _adapter *padapter, const u8