Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-08 Thread Felipe Ferreri Tonello
Hi, On 08/03/16 14:20, Felipe Balbi wrote: > > Hi, > > Krzysztof Opasiak writes: >> [ text/plain ] >> >> >> On 03/08/2016 02:54 PM, Felipe Ferreri Tonello wrote: >> (...) >> > sort of preset library of configfs-based gadget drivers, we still need > these modules. there i

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-08 Thread Felipe Balbi
Hi, Krzysztof Opasiak writes: > [ text/plain ] > > > On 03/08/2016 02:54 PM, Felipe Ferreri Tonello wrote: > (...) > >>> sort of preset library of configfs-based gadget drivers, we still need these modules. >>> >>> there is already a library called libusbg. >> >> By preset library I

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-08 Thread Krzysztof Opasiak
On 03/08/2016 02:54 PM, Felipe Ferreri Tonello wrote: (...) >> >>> sort of preset library of configfs-based gadget drivers, we still need >>> these modules. >> >> there is already a library called libusbg. > > By preset library I meant scripts or little programs that implement the > legacy dri

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-08 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: >>> its easy and simple to setup and use. So I think before we have some >> >> so is configfs. >> >>> sort of preset library of configfs-based gadget drivers, we still need >>> these modules. >> >> there is already a library called libusbg. > > By preset lib

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-08 Thread Felipe Ferreri Tonello
Hi Balbi, On 08/03/16 07:43, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: @@ -63,6 +63,14 @@ static unsigned int out_ports = 1; module_param(out_ports, uint, S_IRUGO); MODULE_PARM_DESC(out_ports, "Number of MIDI output ports");

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-08 Thread Felipe Balbi
Hi, Krzysztof Opasiak writes: > [ text/plain ] > > > On 03/08/2016 08:43 AM, Felipe Balbi wrote: > (...) > > This is necessary because this driver is actually wrong in which is > asking for the host to power itself. This is not specified on USB-MIDI > specification, neither makes any

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-08 Thread Krzysztof Opasiak
On 03/08/2016 08:43 AM, Felipe Balbi wrote: (...) This is necessary because this driver is actually wrong in which is asking for the host to power itself. This is not specified on USB-MIDI specification, neither makes any sense since this configuration is device specific. >>>

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-07 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: >>> @@ -63,6 +63,14 @@ static unsigned int out_ports = 1; >>> module_param(out_ports, uint, S_IRUGO); >>> MODULE_PARM_DESC(out_ports, "Number of MIDI output ports"); >>> >>> +static unsigned int bmAttributes = USB_CONFIG_ATT_ONE; >>>

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-07 Thread Felipe Ferreri Tonello
Hi Balbi, how are you? On 07/03/16 10:59, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: > "Felipe F. Tonello" writes: >> [ text/plain ] >> This gadget uses a bmAttributes and MaxPower that requires the USB > bus to be >> powered from the host, which is not

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-07 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: "Felipe F. Tonello" writes: > [ text/plain ] > This gadget uses a bmAttributes and MaxPower that requires the USB bus to be > powered from the host, which is not correct because this configuration is device > specific, not a USB-

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-07 Thread Felipe Ferreri Tonello
Hi Balbi, On 07/03/16 07:34, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: >> [ text/plain ] >> Hi Balbi, >> >> On March 4, 2016 7:16:42 AM GMT+00:00, Felipe Balbi wrote: >>> >>> Hi, >>> >>> "Felipe F. Tonello" writes: [ text/plain ] This gadget uses a bmAttributes

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-06 Thread Felipe Balbi
Hi, Felipe Ferreri Tonello writes: > [ text/plain ] > Hi Balbi, > > On March 4, 2016 7:16:42 AM GMT+00:00, Felipe Balbi wrote: >> >>Hi, >> >>"Felipe F. Tonello" writes: >>> [ text/plain ] >>> This gadget uses a bmAttributes and MaxPower that requires the USB >>bus to be >>> powered from the h

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-04 Thread Felipe Ferreri Tonello
Hi Balbi, On March 4, 2016 7:16:42 AM GMT+00:00, Felipe Balbi wrote: > >Hi, > >"Felipe F. Tonello" writes: >> [ text/plain ] >> This gadget uses a bmAttributes and MaxPower that requires the USB >bus to be >> powered from the host, which is not correct because this >configuration is device >> s

Re: [PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-03 Thread Felipe Balbi
Hi, "Felipe F. Tonello" writes: > [ text/plain ] > This gadget uses a bmAttributes and MaxPower that requires the USB bus to be > powered from the host, which is not correct because this configuration is > device > specific, not a USB-MIDI requirement. > > This patch adds two modules parameters

[PATCH 3/5] usb: gadget: gmidi: remove bus powered requirement on bmAttributes

2016-03-02 Thread Felipe F. Tonello
This gadget uses a bmAttributes and MaxPower that requires the USB bus to be powered from the host, which is not correct because this configuration is device specific, not a USB-MIDI requirement. This patch adds two modules parameters, bmAttributes and MaxPower, that allows the user to set those f