Re: [PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c

On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote: > Use pr_info() instead of printk() in arch/x86/mm/srat.c. > > Signed-off-by: Tang Chen Please fold patch 4/6 into this patch 3/6 since they both are printk() cleanup on the same file. I do not see why they need to be separated. With that chan

[PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c

Use pr_info() instead of printk() in arch/x86/mm/srat.c. As Joe suggested, define pr_fmt(fmt) as KBUILD_MODNAME ": " fmt to prefix message with "srat: ". Signed-off-by: Tang Chen Signed-off-by: Joe Perches --- arch/x86/mm/srat.c | 17 + 1 files changed, 9 insertions(+), 8 del

Re: [PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c

Hi Joe, On 08/16/2013 03:25 PM, Joe Perches wrote: On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote: arch/x86/mm/srat.c I think it'd be better to use pr_fmt with the conversions to pr_info and pr_err. pr_fmt can prefix the appropriate srat: and so the format strings do not need it. Someth

Re: [PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c

On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote: > arch/x86/mm/srat.c I think it'd be better to use pr_fmt with the conversions to pr_info and pr_err. pr_fmt can prefix the appropriate srat: and so the format strings do not need it. Something like: --- arch/x86/mm/srat.c | 31 +++

[PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c

Use pr_info() instead of printk() in arch/x86/mm/srat.c. Signed-off-by: Tang Chen --- arch/x86/mm/srat.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/mm/srat.c b/arch/x86/mm/srat.c index 71411aa..6286e89 100644 --- a/arch/x86/mm/srat.c +++ b/arch/x