Re: [PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-18 Thread John Garry
/* by default, task resp is complete */ -static void slot_err_v1_hw(struct hisi_hba *hisi_hba, - struct sas_task *task, - struct hisi_sas_slot *slot) +static void slot_err_v1_hw(struct hisi_hba *hisi_hba, struct sas_task *task, + struct hisi_sas_slot *s

Re: [PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-17 Thread Hannes Reinecke
On 02/16/2016 05:13 PM, John Garry wrote: > On 16/02/2016 15:31, Hannes Reinecke wrote: >> On 02/16/2016 01:22 PM, John Garry wrote: >>> When TRANS_TX_CREDIT_TIMEOUT_ERR or >>> TRANS_TX_CLOSE_NORMAL_ERR errors occur for a >>> command, the command should be re-attempted. >>> >>> Signed-off-by: John

Re: [PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-16 Thread John Garry
On 16/02/2016 15:31, Hannes Reinecke wrote: On 02/16/2016 01:22 PM, John Garry wrote: When TRANS_TX_CREDIT_TIMEOUT_ERR or TRANS_TX_CLOSE_NORMAL_ERR errors occur for a command, the command should be re-attempted. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 22 ++

Re: [PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-16 Thread Hannes Reinecke
On 02/16/2016 01:22 PM, John Garry wrote: > When TRANS_TX_CREDIT_TIMEOUT_ERR or > TRANS_TX_CLOSE_NORMAL_ERR errors occur for a > command, the command should be re-attempted. > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 22 ++ > 1 file changed

[PATCH 3/6] hisi_sas: use slot abort in v1 hw

2016-02-16 Thread John Garry
When TRANS_TX_CREDIT_TIMEOUT_ERR or TRANS_TX_CLOSE_NORMAL_ERR errors occur for a command, the command should be re-attempted. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/s