Re: [PATCH 3/6] mm, memcg: Prevent memory.low load/store tearing

2020-06-12 Thread Chris Down
Hi Michal, Good catch! Andrew and I must have missed these when massaging the commits with other stuff in -mm, which is totally understandable considering the amount of places being touched by this and other patch series at the same time. Just goes to show how complex it can be sometimes, sinc

Re: [PATCH 3/6] mm, memcg: Prevent memory.low load/store tearing

2020-06-12 Thread Michal Koutný
Hello. I see suspicious asymmetry, in the current mainline: > WRITE_ONCE(memcg->memory.emin, effective_protection(usage, parent_usage, > READ_ONCE(memcg->memory.min), > READ_ONCE(parent->memory.emin), > atomic_long_read(&paren