Re: [PATCH 3/6] perf timechart: add support for displaying only tasks related data

2013-10-31 Thread Namhyung Kim
On Tue, 29 Oct 2013 13:33:29 +0400, Stanislav Fomichev wrote: >> Hmm.. double negation is always confusing to me. :-/ How about making >> it a boolean option that sets "task_only" variable? > Ok. > >> Also need to update the doc. And what if user gives -P and -T options >> at the same time? > Is

Re: [PATCH 3/6] perf timechart: add support for displaying only tasks related data

2013-10-29 Thread Stanislav Fomichev
> Hmm.. double negation is always confusing to me. :-/ How about making > it a boolean option that sets "task_only" variable? Ok. > Also need to update the doc. And what if user gives -P and -T options > at the same time? Is something like this is enough (or you'd like some printout with error d

Re: [PATCH 3/6] perf timechart: add support for displaying only tasks related data

2013-10-29 Thread Namhyung Kim
On Tue, 22 Oct 2013 14:56:49 +0400, Stanislav Fomichev wrote: > In order to make SVG smaller and faster to browse add possibility to > switch off power related information with -T switch. > > Signed-off-by: Stanislav Fomichev > --- > tools/perf/builtin-timechart.c | 15 ++- > 1 file c

[PATCH 3/6] perf timechart: add support for displaying only tasks related data

2013-10-22 Thread Stanislav Fomichev
In order to make SVG smaller and faster to browse add possibility to switch off power related information with -T switch. Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-ti