Re: [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands

2021-02-01 Thread Vinod Koul
On 01-02-21, 15:50, Srinivas Kandagatla wrote: > > > On 01/02/2021 14:16, Vinod Koul wrote: > > > /* Configure number of retries of a read/write cmd */ > > > - ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR, SWRM_RD_WR_CMD_RETRIES); > > > + if (ctrl->version_major == 1 &&

Re: [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands

2021-02-01 Thread Srinivas Kandagatla
On 01/02/2021 14:16, Vinod Koul wrote: /* Configure number of retries of a read/write cmd */ - ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR, SWRM_RD_WR_CMD_RETRIES); + if (ctrl->version_major == 1 && ctrl->version_minor >= 5 && + ctrl->version_step >= 1) { why

Re: [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands

2021-02-01 Thread Vinod Koul
On 29-01-21, 17:32, Srinivas Kandagatla wrote: > version 1.5.1 and higher IPs of this controller required to set > continue execution on ingored command flag. This patch sets this flag. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/soundwire/qcom.c | 12 +++- > 1 file changed,

Re: [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands

2021-01-29 Thread Pierre-Louis Bossart
On 1/29/21 11:32 AM, Srinivas Kandagatla wrote: version 1.5.1 and higher IPs of this controller required to set continue execution on ingored command flag. This patch sets this flag. typo: ignored.

[PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands

2021-01-29 Thread Srinivas Kandagatla
version 1.5.1 and higher IPs of this controller required to set continue execution on ingored command flag. This patch sets this flag. Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git