Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> Sorry, I was unclear. I have no problem with white space changes on > their own or when they are on the same line as something else you're > changing. > > What I meant is that when you're just moving functions around then don't > mix unrelated white space changes into that patch. I have

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> Sorry, I was unclear. I have no problem with white space changes on > their own or when they are on the same line as something else you're > changing. > > What I meant is that when you're just moving functions around then don't > mix unrelated white space changes into that patch. I have

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: > > From: Ben Evans > > > > Remove all obdo related functions from lustre_idl.h > > Create lustre_odbo.h. Include where appropriate. > > Make the functions lustre_get_wire_obdo and > > lustre_set_wire_obdo to not

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: > > From: Ben Evans > > > > Remove all obdo related functions from lustre_idl.h > > Create lustre_odbo.h. Include where appropriate. > > Make the functions lustre_get_wire_obdo and > > lustre_set_wire_obdo to not be inlined

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: > From: Ben Evans > > Remove all obdo related functions from lustre_idl.h > Create lustre_odbo.h. Include where appropriate. > Make the functions lustre_get_wire_obdo and > lustre_set_wire_obdo to not be inlined

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: > From: Ben Evans > > Remove all obdo related functions from lustre_idl.h > Create lustre_odbo.h. Include where appropriate. > Make the functions lustre_get_wire_obdo and > lustre_set_wire_obdo to not be inlined functions. Breaks

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

Sorry, I was unclear. I have no problem with white space changes on their own or when they are on the same line as something else you're changing. What I meant is that when you're just moving functions around then don't mix unrelated white space changes into that patch. I have automated scripts

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

Sorry, I was unclear. I have no problem with white space changes on their own or when they are on the same line as something else you're changing. What I meant is that when you're just moving functions around then don't mix unrelated white space changes into that patch. I have automated scripts

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> On Dec 5, 2016, at 13:50, Dan Carpenter wrote: > > On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: >> -__u32 local_flags = 0; >> +u32 local_flags = 0; > >> -if (local_flags != 0) { >> +if (local_flags) { > > Please avoid these

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

> On Dec 5, 2016, at 13:50, Dan Carpenter wrote: > > On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: >> -__u32 local_flags = 0; >> +u32 local_flags = 0; > >> -if (local_flags != 0) { >> +if (local_flags) { > > Please avoid these unrelated white space changes.

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: > - __u32 local_flags = 0; > + u32 local_flags = 0; > - if (local_flags != 0) { > + if (local_flags) { Please avoid these unrelated white space changes. regards, dan carpenter

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: > - __u32 local_flags = 0; > + u32 local_flags = 0; > - if (local_flags != 0) { > + if (local_flags) { Please avoid these unrelated white space changes. regards, dan carpenter

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

Hi Ben, [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20161202] [cannot apply to v4.9-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

Hi Ben, [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20161202] [cannot apply to v4.9-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

From: Ben Evans Remove all obdo related functions from lustre_idl.h Create lustre_odbo.h. Include where appropriate. Make the functions lustre_get_wire_obdo and lustre_set_wire_obdo to not be inlined functions. Signed-off-by: Ben Evans Intel-bug-id:

[PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

From: Ben Evans Remove all obdo related functions from lustre_idl.h Create lustre_odbo.h. Include where appropriate. Make the functions lustre_get_wire_obdo and lustre_set_wire_obdo to not be inlined functions. Signed-off-by: Ben Evans Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401