Re: [PATCH 3/6] statx: Ext4: Return enhanced file attributes

2016-05-08 Thread Christoph Hellwig
On Fri, Apr 29, 2016 at 01:57:59PM +0100, David Howells wrote: > (3) FS_xxx_FL flags are returned as for ioctl(FS_IOC_GETFLAGS), setting > STATX_IOC_FLAGS. Doesn't look like it is. Which actually is a good thing given how much of a mess FS_IOC_GETFLAGS is.

Re: [PATCH 3/6] statx: Ext4: Return enhanced file attributes

2016-05-03 Thread David Howells
Andreas Dilger wrote: > > (3) FS_xxx_FL flags are returned as for ioctl(FS_IOC_GETFLAGS), setting > > STATX_IOC_FLAGS. > > I don't see where this is implemented in this patch, and it should be > removed from the commit message to avoid confusion. Oops - I forgot to remove it from the other

Re: [PATCH 3/6] statx: Ext4: Return enhanced file attributes

2016-05-02 Thread Andreas Dilger
On Apr 29, 2016, at 6:57 AM, David Howells wrote: > > Return enhanced file attributes from the Ext4 filesystem. This includes > the following: > > (1) The inode creation time (i_crtime) as i_btime, setting STATX_BTIME. > > (2) The inode i_version as st_version if a file with I_VERSION set or a

[PATCH 3/6] statx: Ext4: Return enhanced file attributes

2016-04-29 Thread David Howells
Return enhanced file attributes from the Ext4 filesystem. This includes the following: (1) The inode creation time (i_crtime) as i_btime, setting STATX_BTIME. (2) The inode i_version as st_version if a file with I_VERSION set or a directory, setting STATX_VERSION. (3) FS_xxx_FL flags ar