Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-13 Thread J. Bruce Fields
On Fri, Jan 13, 2017 at 07:57:06PM +, Al Viro wrote: > On Fri, Jan 13, 2017 at 02:03:57PM -0500, J. Bruce Fields wrote: > > On Fri, Jan 13, 2017 at 10:52:54AM -0800, Christoph Hellwig wrote: > > > On Fri, Jan 13, 2017 at 12:39:12PM -0500, J. Bruce Fields wrote: > > > > If we're going to reject

Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-13 Thread Al Viro
On Fri, Jan 13, 2017 at 02:03:57PM -0500, J. Bruce Fields wrote: > On Fri, Jan 13, 2017 at 10:52:54AM -0800, Christoph Hellwig wrote: > > On Fri, Jan 13, 2017 at 12:39:12PM -0500, J. Bruce Fields wrote: > > > If we're going to reject patches that don't implement get_parent (and I > > > think we sho

Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-13 Thread Christoph Hellwig
On Fri, Jan 13, 2017 at 12:39:12PM -0500, J. Bruce Fields wrote: > If we're going to reject patches that don't implement get_parent (and I > think we should), then we should replace "optional but strongly > recommended" there by just "mandatory". Any objections? In theory yes - we'll just need an

Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-13 Thread J. Bruce Fields
On Fri, Jan 13, 2017 at 10:52:54AM -0800, Christoph Hellwig wrote: > On Fri, Jan 13, 2017 at 12:39:12PM -0500, J. Bruce Fields wrote: > > If we're going to reject patches that don't implement get_parent (and I > > think we should), then we should replace "optional but strongly > > recommended" ther

Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-13 Thread J. Bruce Fields
On Wed, Jan 04, 2017 at 06:53:31AM +0100, Fabian Frederick wrote: > > > > On 03 January 2017 at 23:29 Al Viro wrote: > > > > > > On Tue, Jan 03, 2017 at 10:30:39PM +0100, Fabian Frederick wrote: > > > Add standard functions making AFFS work with NFS. > > > > > > Functions based on ext4 implement

Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-04 Thread Fabian Frederick
> On 03 January 2017 at 23:29 Al Viro wrote: > > > On Tue, Jan 03, 2017 at 10:30:39PM +0100, Fabian Frederick wrote: > > Add standard functions making AFFS work with NFS. > > > > Functions based on ext4 implementation. > > Tested on loop device. > > How the hell is that supposed to work with col

Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-03 Thread Fabian Frederick
> On 03 January 2017 at 23:29 Al Viro wrote: > > > On Tue, Jan 03, 2017 at 10:30:39PM +0100, Fabian Frederick wrote: > > Add standard functions making AFFS work with NFS. > > > > Functions based on ext4 implementation. > > Tested on loop device. > > How the hell is that supposed to work with col

Re: [PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-03 Thread Al Viro
On Tue, Jan 03, 2017 at 10:30:39PM +0100, Fabian Frederick wrote: > Add standard functions making AFFS work with NFS. > > Functions based on ext4 implementation. > Tested on loop device. How the hell is that supposed to work with cold dcache? You don't have ->get_parent() there at all... There

[PATCH 3/6 linux-next] fs/affs: make affs exportable

2017-01-03 Thread Fabian Frederick
Add standard functions making AFFS work with NFS. Functions based on ext4 implementation. Tested on loop device. Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 1 + fs/affs/namei.c | 40 fs/affs/super.c | 1 + 3 files changed, 42 insertions(+)