Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: > On Wed, 2007-05-23 at 12:11 -0400, Jason Baron wrote: > > On Wed, 23 May 2007, Peter Zijlstra wrote: > > > > > On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: > > > > On Wed, 23 May 2007, Peter Zijlstra wrote: > > > > > > > > > Count lock

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Peter Zijlstra
On Wed, 2007-05-23 at 12:11 -0400, Jason Baron wrote: > On Wed, 23 May 2007, Peter Zijlstra wrote: > > > On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: > > > On Wed, 23 May 2007, Peter Zijlstra wrote: > > > > > > > Count lock contention events per lock class. Additionally track the > > >

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: > On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: > > On Wed, 23 May 2007, Peter Zijlstra wrote: > > > > > Count lock contention events per lock class. Additionally track the first > > > four > > > callsites that resulted in the contention. > >

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Peter Zijlstra
On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: > On Wed, 23 May 2007, Peter Zijlstra wrote: > > > Count lock contention events per lock class. Additionally track the first > > four > > callsites that resulted in the contention. > > > > I think that we need the total number of locking

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: > Count lock contention events per lock class. Additionally track the first four > callsites that resulted in the contention. > I think that we need the total number of locking calls, not just the total number of *contended* locking calls, in order

[PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Peter Zijlstra
Count lock contention events per lock class. Additionally track the first four callsites that resulted in the contention. /proc/lock_contentions - gives a single line per lock class: <(write) contentions> Followed by another three columns per contention point: writing a '0' to the

[PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Peter Zijlstra
Count lock contention events per lock class. Additionally track the first four callsites that resulted in the contention. /proc/lock_contentions - gives a single line per lock class: class name (write) contentions read contentions Followed by another three columns per contention point:

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: Count lock contention events per lock class. Additionally track the first four callsites that resulted in the contention. I think that we need the total number of locking calls, not just the total number of *contended* locking calls, in order to

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Peter Zijlstra
On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: Count lock contention events per lock class. Additionally track the first four callsites that resulted in the contention. I think that we need the total number of locking calls, not

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: Count lock contention events per lock class. Additionally track the first four callsites that resulted in the contention. I think

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Peter Zijlstra
On Wed, 2007-05-23 at 12:11 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: Count lock contention events per lock class. Additionally track the first four

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: On Wed, 2007-05-23 at 12:11 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: Count lock contention events per