Re: [PATCH 3/7] nfsd: remove redundant i_lookup check

2016-07-24 Thread J. Bruce Fields
On Sun, Jul 24, 2016 at 03:23:07PM +0100, Al Viro wrote: > On Sun, Jul 24, 2016 at 08:10:14AM -0400, J. Bruce Fields wrote: > > On Sun, Jul 24, 2016 at 01:22:06AM +0100, Al Viro wrote: > > > On Fri, Jul 22, 2016 at 01:48:52PM -0400, J. Bruce Fields wrote: > > > > From: "J. Bruce Fields" > > > > >

Re: [PATCH 3/7] nfsd: remove redundant i_lookup check

2016-07-24 Thread Al Viro
On Sun, Jul 24, 2016 at 08:10:14AM -0400, J. Bruce Fields wrote: > On Sun, Jul 24, 2016 at 01:22:06AM +0100, Al Viro wrote: > > On Fri, Jul 22, 2016 at 01:48:52PM -0400, J. Bruce Fields wrote: > > > From: "J. Bruce Fields" > > > > > > I'm not sure why this was added. It doesn't seem necessary, a

Re: [PATCH 3/7] nfsd: remove redundant i_lookup check

2016-07-24 Thread J. Bruce Fields
On Sun, Jul 24, 2016 at 01:22:06AM +0100, Al Viro wrote: > On Fri, Jul 22, 2016 at 01:48:52PM -0400, J. Bruce Fields wrote: > > From: "J. Bruce Fields" > > > > I'm not sure why this was added. It doesn't seem necessary, and no > > other caller does this. > > lookup_one_len() will explode if you

Re: [PATCH 3/7] nfsd: remove redundant i_lookup check

2016-07-23 Thread Al Viro
On Fri, Jul 22, 2016 at 01:48:52PM -0400, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > I'm not sure why this was added. It doesn't seem necessary, and no > other caller does this. lookup_one_len() will explode if you call it for non-directory (== !d_can_lookup(), i.e. something without

[PATCH 3/7] nfsd: remove redundant i_lookup check

2016-07-22 Thread J. Bruce Fields
From: "J. Bruce Fields" I'm not sure why this was added. It doesn't seem necessary, and no other caller does this. Signed-off-by: J. Bruce Fields --- fs/nfsd/vfs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index fba8e7e521e0..7ae3b5a72a4d 100644 --- a