Re: [PATCH 3/7] perf hists: Introduce hist_period_print functions

2012-08-21 Thread Namhyung Kim
On Mon, 20 Aug 2012 10:08:26 -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Aug 20, 2012 at 01:52:07PM +0900, Namhyung Kim escreveu: >> From: Namhyung Kim >> >> Current hist print functions are messy. Refactor them using the hpp > > Why? I'm not saying they aren't, just curious about the lack o

Re: [PATCH 3/7] perf hists: Introduce hist_period_print functions

2012-08-20 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 20, 2012 at 01:52:07PM +0900, Namhyung Kim escreveu: > From: Namhyung Kim > > Current hist print functions are messy. Refactor them using the hpp Why? I'm not saying they aren't, just curious about the lack of an explanation as to why they would be. Please add it to this changelog co

[PATCH 3/7] perf hists: Introduce hist_period_print functions

2012-08-19 Thread Namhyung Kim
From: Namhyung Kim Current hist print functions are messy. Refactor them using the hpp callbacks and move common code to ui/hist.c. This will make it easy to add new features. Signed-off-by: Namhyung Kim --- tools/perf/Makefile| 2 + tools/perf/builtin-diff.c | 1 + tools/perf/ui/

[PATCH 3/7] perf hists: Introduce hist_period_print functions

2012-08-06 Thread Namhyung Kim
From: Namhyung Kim Current hist print functions are messy. Refactor them using the hpp callbacks. This will make it easy to add new features. Signed-off-by: Namhyung Kim --- tools/perf/builtin-diff.c | 1 + tools/perf/ui/hist.c | 490 +++--- tools