Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-06 Thread Anton Vorontsov
Hi Paul, On Sat, May 05, 2007 at 05:29:56PM +0300, Paul Sokolovsky wrote: > Hello Anton, > > But in real world, it's rather common to colloquially name > such kind of power "AC", and that's "term" is known to many-many > people, and intuitively understood even for those, who didn't hit it

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-06 Thread Anton Vorontsov
On Sun, May 06, 2007 at 03:06:04PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 05 May 2007, Paul Sokolovsky wrote: > > Saturday, May 5, 2007, 4:46:26 PM, you wrote: > > > On Sat, 2007-05-05 at 00:54 -0300, Henrique de Moraes Holschuh wrote: > > >> Given that USB-power *is* usually also "dum

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-06 Thread Anton Vorontsov
On Sat, May 05, 2007 at 03:39:40PM +0200, pHilipp Zabel wrote: > > > secondary notion too, as that is common. It would be generic. > > > > > > Or maybe I just didn't get the idea behind the "type" attribute :-) > > > > > > I'd appreciate if these were documented in the text file. > > > > I think I

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-06 Thread Anton Vorontsov
On Sun, May 06, 2007 at 03:09:37PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 05 May 2007, ian wrote: > > On Sat, 2007-05-05 at 00:54 -0300, Henrique de Moraes Holschuh wrote: > > > > > Given that USB-power *is* usually also "dumb" (i.e. it doesn't do any > > > control signaling over the

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-06 Thread Henrique de Moraes Holschuh
On Sat, 05 May 2007, ian wrote: > On Sat, 2007-05-05 at 00:54 -0300, Henrique de Moraes Holschuh wrote: > > > Given that USB-power *is* usually also "dumb" (i.e. it doesn't do any > > control signaling over the USB bus for power-control purposes), > > it might be dumb, but it is useful to know we

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-06 Thread Henrique de Moraes Holschuh
On Sat, 05 May 2007, Paul Sokolovsky wrote: > Saturday, May 5, 2007, 4:46:26 PM, you wrote: > > On Sat, 2007-05-05 at 00:54 -0300, Henrique de Moraes Holschuh wrote: > >> Given that USB-power *is* usually also "dumb" (i.e. it doesn't do any > >> control signaling over the USB bus for power-control

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-05 Thread Jan Engelhardt
On May 5 2007 15:39, pHilipp Zabel wrote: >> > > > +enum power_supply_type { >> > > > + POWER_SUPPLY_TYPE_BATTERY = 0, >> > > > + POWER_SUPPLY_TYPE_UPS, >> > > > + POWER_SUPPLY_TYPE_AC, >> > > > + POWER_SUPPLY_TYPE_USB, >> > > > +}; >> > > >> > > How about dumb (non-USB) D

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-05 Thread ian
On Sat, 2007-05-05 at 00:54 -0300, Henrique de Moraes Holschuh wrote: > Given that USB-power *is* usually also "dumb" (i.e. it doesn't do any > control signaling over the USB bus for power-control purposes), it might be dumb, but it is useful to know wether the PDA is charging from usb or mains p

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-05 Thread Damien Tournoud
Paul Sokolovsky wrote: There's actually a nice and terse term for that - mains, but I wonder how well non-English speaking people are familiar with it (I personally saw them only in manuals, which, as well known, nobody reads). I, for one, wasn't :) My 2 cents: ADAPTER seems better than AC, wh

Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-05 Thread Anton Vorontsov
Hello Henrique, Shem, On Sat, May 05, 2007 at 12:54:13AM -0300, Henrique de Moraes Holschuh wrote: > On Fri, 04 May 2007, Shem Multinymous wrote: > > >+enum power_supply_type { > > >+ POWER_SUPPLY_TYPE_BATTERY = 0, > > >+ POWER_SUPPLY_TYPE_UPS, > > >+ POWER_SUPPLY_TYPE_AC, > > >+

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-05 Thread Paul Sokolovsky
Hello ian, Saturday, May 5, 2007, 4:46:26 PM, you wrote: > On Sat, 2007-05-05 at 00:54 -0300, Henrique de Moraes Holschuh wrote: >> Given that USB-power *is* usually also "dumb" (i.e. it doesn't do any >> control signaling over the USB bus for power-control purposes), > it might be dumb, but it

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-05 Thread Paul Sokolovsky
Hello Anton, Saturday, May 5, 2007, 3:32:30 PM, you wrote: > Hello Henrique, Shem, > On Sat, May 05, 2007 at 12:54:13AM -0300, Henrique de Moraes Holschuh wrote: >> On Fri, 04 May 2007, Shem Multinymous wrote: >> > >+enum power_supply_type { >> > >+ POWER_SUPPLY_TYPE_BATTERY = 0, >> > >+

Re: [Kernel-discuss] Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-05 Thread pHilipp Zabel
On 5/5/07, Anton Vorontsov <[EMAIL PROTECTED]> wrote: Hello Henrique, Shem, On Sat, May 05, 2007 at 12:54:13AM -0300, Henrique de Moraes Holschuh wrote: > On Fri, 04 May 2007, Shem Multinymous wrote: > > >+enum power_supply_type { > > >+ POWER_SUPPLY_TYPE_BATTERY = 0, > > >+ POWER_SU

Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-04 Thread Henrique de Moraes Holschuh
On Fri, 04 May 2007, Shem Multinymous wrote: > >+enum power_supply_type { > >+ POWER_SUPPLY_TYPE_BATTERY = 0, > >+ POWER_SUPPLY_TYPE_UPS, > >+ POWER_SUPPLY_TYPE_AC, > >+ POWER_SUPPLY_TYPE_USB, > >+}; > > How about dumb (non-USB) DC power? Any reason to distinguish it from A

Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-03 Thread Shem Multinymous
On 5/3/07, Anton Vorontsov <[EMAIL PROTECTED]> wrote: This class is result of "external power" and "battery" classes merge, as suggested by David Woodhouse. He also implemented uevent support. Looks great. In particular, the policies you've chosen for the attributes and units are very reasonabl

Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-03 Thread Anton Vorontsov
On Thu, May 03, 2007 at 03:53:46PM -0700, Greg KH wrote: > On Fri, May 04, 2007 at 01:31:39AM +0400, Anton Vorontsov wrote: > > This class is result of "external power" and "battery" classes merge, > > as suggested by David Woodhouse. He also implemented uevent support. > > > > Here how userspace

Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-03 Thread CaT
On Thu, May 03, 2007 at 03:53:46PM -0700, Greg KH wrote: > > # cat /sys/class/power\ supply/ > > ac/ main-battery/ usb/ > > Um, shouldn't that be an error? Isn't /sys/class/power\ supply/ a > directory? I think that's more of a case of: cat /sys/class/power\ su

Re: [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-03 Thread Greg KH
On Fri, May 04, 2007 at 01:31:39AM +0400, Anton Vorontsov wrote: > This class is result of "external power" and "battery" classes merge, > as suggested by David Woodhouse. He also implemented uevent support. > > Here how userspace seeing it now: > > # ls /sys/class/power\ supply/ > ac

Re: [Kernel-discuss] [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-03 Thread Anton Vorontsov
On Thu, May 03, 2007 at 11:14:26PM +0100, ian wrote: > On Fri, 2007-05-04 at 01:31 +0400, Anton Vorontsov wrote: > > # cat /sys/class/power\ supply/ac/type > > AC > > > > # cat /sys/class/power\ supply/usb/type > > USB > > isnt that a bit redundant? Let me note that

Re: [Kernel-discuss] [PATCH 3/8] Universal power supply class (was: battery class)

2007-05-03 Thread ian
On Fri, 2007-05-04 at 01:31 +0400, Anton Vorontsov wrote: > # cat /sys/class/power\ supply/ac/type > AC > > # cat /sys/class/power\ supply/usb/type > USB isnt that a bit redundant? I'd have thought sys/class/power\ supply/supplyX/type would be better? - To unsubscri

[PATCH 3/8] Universal power supply class (was: battery class)

2007-05-03 Thread Anton Vorontsov
This class is result of "external power" and "battery" classes merge, as suggested by David Woodhouse. He also implemented uevent support. Here how userspace seeing it now: # ls /sys/class/power\ supply/ ac main-battery usb # cat /sys/class/power\ supply/ ac/