Re: [PATCH 3/8] kcsan: Skew delay to be longer for certain access types

2020-07-21 Thread peterz
On Tue, Jul 21, 2020 at 04:26:54PM +0200, Marco Elver wrote: > I'll rewrite the commit message: > > For compound instrumentation and assert accesses, skew the > watchpoint delay to be longer if randomized. This is useful to > improve race detection for such accesses. > >

Re: [PATCH 3/8] kcsan: Skew delay to be longer for certain access types

2020-07-21 Thread Marco Elver
On Tue, Jul 21, 2020 at 04:05PM +0200, Peter Zijlstra wrote: > On Tue, Jul 21, 2020 at 12:30:11PM +0200, Marco Elver wrote: > > For compound instrumentation and assert accesses, skew the watchpoint > > delay to be longer. We still shouldn't exceed the maximum delays, but it > > is safe to skew the

Re: [PATCH 3/8] kcsan: Skew delay to be longer for certain access types

2020-07-21 Thread Peter Zijlstra
On Tue, Jul 21, 2020 at 12:30:11PM +0200, Marco Elver wrote: > For compound instrumentation and assert accesses, skew the watchpoint > delay to be longer. We still shouldn't exceed the maximum delays, but it > is safe to skew the delay for these accesses. Complete lack of actual justification..

[PATCH 3/8] kcsan: Skew delay to be longer for certain access types

2020-07-21 Thread Marco Elver
For compound instrumentation and assert accesses, skew the watchpoint delay to be longer. We still shouldn't exceed the maximum delays, but it is safe to skew the delay for these accesses. Signed-off-by: Marco Elver --- kernel/kcsan/core.c | 10 +++--- 1 file changed, 7 insertions(+), 3