Re: [PATCH 3/8] mm: vmscan: move inactive_list_is_low() swap check to the caller

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 10:47:58, Johannes Weiner wrote: > inactive_list_is_low() should be about one thing: checking the ratio > between inactive and active list. Kitchensink checks like the one for > swap space makes the function hard to use and modify its > callsites. Luckly, most callers already have

Re: [PATCH 3/8] mm: vmscan: move inactive_list_is_low() swap check to the caller

2019-10-22 Thread Roman Gushchin
On Tue, Oct 22, 2019 at 10:47:58AM -0400, Johannes Weiner wrote: > inactive_list_is_low() should be about one thing: checking the ratio > between inactive and active list. Kitchensink checks like the one for > swap space makes the function hard to use and modify its > callsites. Luckly, most

[PATCH 3/8] mm: vmscan: move inactive_list_is_low() swap check to the caller

2019-10-22 Thread Johannes Weiner
inactive_list_is_low() should be about one thing: checking the ratio between inactive and active list. Kitchensink checks like the one for swap space makes the function hard to use and modify its callsites. Luckly, most callers already have an understanding of the swap situation, so it's easy to