Re: [PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc()

On 2 September 2015 at 18:20, Doug Anderson wrote: > Ulf, > > On Wed, Sep 2, 2015 at 4:38 AM, Ulf Hansson wrote: >>> +/** >>> + * mmc_regulator_set_vqmmc - Set VQMMC as per the ios >>> + * >>> + * For 3.3V signaling, we try to match VQMMC to VMMC as closely as >>> possible. >> >> Looking at the

Re: [PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc()

Ulf, On Wed, Sep 2, 2015 at 4:38 AM, Ulf Hansson wrote: >> +/** >> + * mmc_regulator_set_vqmmc - Set VQMMC as per the ios >> + * >> + * For 3.3V signaling, we try to match VQMMC to VMMC as closely as possible. > > Looking at the code, I don't think this statement is entirely true. > Isn't it so t

Re: [PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc()

On 31 August 2015 at 20:24, Heiko Stuebner wrote: > From: Douglas Anderson > > This adds logic to the MMC core to set VQMMC. This is expected to be > called by MMC drivers like dw_mmc as part of (or instead of) their > start_signal_voltage_switch() callback. > > A few notes: > > * When setting t

[PATCH 3/8] mmc: core: Add mmc_regulator_set_vqmmc()

From: Douglas Anderson This adds logic to the MMC core to set VQMMC. This is expected to be called by MMC drivers like dw_mmc as part of (or instead of) their start_signal_voltage_switch() callback. A few notes: * When setting the signal voltage to 3.3V we do our best to make VQMMC and VMMC