Re: [PATCH 3/8] mutex: Modify the way optimistic spinners are queued

2014-02-10 Thread Peter Zijlstra
On Mon, Feb 10, 2014 at 05:33:18PM -0800, Jason Low wrote: > > + mcs_spin_lock(&lock->mcs_lock); > > Where did the mcs node go? :) Bugger, that's what I get for not compiling each patch in the series.. :-/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

Re: [PATCH 3/8] mutex: Modify the way optimistic spinners are queued

2014-02-10 Thread Jason Low
On Mon, 2014-02-10 at 20:58 +0100, Peter Zijlstra wrote: > Cc: t...@linutronix.de > Cc: r...@redhat.com > Cc: a...@linux-foundation.org > Cc: davidl...@hp.com > Cc: h...@zytor.com > Cc: a...@firstfloor.org > Cc: as...@hp.com > Cc: mi...@kernel.org > Cc: scott.nor...@hp.com > Cc: chegu_vi...@hp.com

[PATCH 3/8] mutex: Modify the way optimistic spinners are queued

2014-02-10 Thread Peter Zijlstra
The mutex->spin_mlock was introduced in order to ensure that only 1 thread spins for lock acquisition at a time to reduce cache line contention. When lock->owner is NULL and the lock->count is still not 1, the spinner(s) will continually release and obtain the lock->spin_mlock. This can generate qu