Re: [PATCH 3/8] phy: rockchip-usb: move per-phy init into a separate function

2015-11-04 Thread Doug Anderson
Heiko, On Wed, Nov 4, 2015 at 1:44 PM, Heiko Stuebner wrote: > for_each_available_child_of_node(dev->of_node, child) { > - rk_phy = devm_kzalloc(dev, sizeof(*rk_phy), GFP_KERNEL); > - if (!rk_phy) > - return -ENOMEM; > - > -

[PATCH 3/8] phy: rockchip-usb: move per-phy init into a separate function

2015-11-04 Thread Heiko Stuebner
This unclutters the loop in probe a lot and makes current (and future) error handling easier to read. Signed-off-by: Heiko Stuebner --- drivers/phy/phy-rockchip-usb.c | 82 -- 1 file changed, 47 insertions(+), 35 deletions(-) diff --git

[PATCH 3/8] phy: rockchip-usb: move per-phy init into a separate function

2015-11-04 Thread Heiko Stuebner
This unclutters the loop in probe a lot and makes current (and future) error handling easier to read. Signed-off-by: Heiko Stuebner --- drivers/phy/phy-rockchip-usb.c | 82 -- 1 file changed, 47 insertions(+), 35 deletions(-) diff --git

Re: [PATCH 3/8] phy: rockchip-usb: move per-phy init into a separate function

2015-11-04 Thread Doug Anderson
Heiko, On Wed, Nov 4, 2015 at 1:44 PM, Heiko Stuebner wrote: > for_each_available_child_of_node(dev->of_node, child) { > - rk_phy = devm_kzalloc(dev, sizeof(*rk_phy), GFP_KERNEL); > - if (!rk_phy) > - return -ENOMEM; > -